preliminary unit test for bookmarks and related stuff

Bug #983821 reported by vcap
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

Attached is a serie of patches to add a unit test for bookmarks (what i came up with doesn't actually test much, though)
also it has a patch to turn on tracing of sql queries on the bookmarks db if build with G_ENABLE_DEBUG and the MIDORI_BOOKMARKS_DEBUG env var is set.

merging gotik's patch on top of that is no big problem.

Revision history for this message
vcap (vcappe) wrote :
Revision history for this message
vcap (vcappe) wrote :
Revision history for this message
vcap (vcappe) wrote :
Revision history for this message
vcap (vcappe) wrote :
vcap (vcappe)
description: updated
Revision history for this message
Olli (coderkun-deactivatedaccount) wrote :

I finally added the column “position” for sorting the bookmarks in the future without the need for another conversion to my patch bug 836707.
Is it possible to merge? I think, we have a final patch then.

Revision history for this message
Alexander Butenko (avb) wrote :

The main reason why patch is still not pushed into master is because you are not sure about database structure.
If we will push it to master then changes will high nightly builds and we will need to add one more migration procedure on midori startup.

Once you feel that you are done with new DB structure then it will be landed. Im looking forward on landing patch in order for it to get good testing from nightly builds users before the next release.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Lovely work on moving the bookmark code and adding unit testing, you may call it a skeleton, I will call it a great start at quality assurance for bookmarks. All committed.

Changed in midori:
status: New → Fix Committed
tags: added: bookmarks tests
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.