Build failure in extensions/external-download-manager.vala

[natano]

For me the build of extensions/external-download-manager.vala fails. Compiling without extensions works fine.
Until d0ef9c65750d14989872303092de8a6ad58ce1d0 (inclusive) compiling works fine with extensions.

== about:version ==
WebKitGTK+ 1.6.3 (1.6.3)
GTK+ 2.24.6 (2.24.6)
Glib 2.30.0 (2.30.0)
libsoup 2.36.0
cairo 1.10.2 (1.10.2)
libnotify 0.7.4
single instance libunique 1.1.6
Platform X11; Linux x86_64
Identification Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-us) AppleWebKit/535+ (KHTML, like Gecko) Version/5.0 Safari/535.4+ Midori/0.4
Video Formats H264 [x] Ogg Theora [x] WebM [x]

[André Stösel (ivaldi)]

This is not a midori bug.
The bug is located in the vapi of libsoup (0.14) and is already fixed in the vapi which is delivered with vala 0.16.

[Liviu Andronic (landronimirc)]

The trouble is that this dependency requirement---vala 0.16---makes Midori incompatible with _all_ Ubuntu distributions (and countless others, I suspect). Currently all Ubuntu distributions ship valac-0.14.2 or older [1] (but for the yet to be released Ubuntu Precise).

Current GIT snapshots fail to build on Natty and Oneiric. [2]

[1] http://packages.ubuntu.com/search?keywords=valac&searchon=names&suite=all&section=all
[2] https://launchpad.net/~midori/+archive/midori-dev/+packages

[André Stösel (ivaldi)]

Sorry, I was wrong - it works with <= 0.14 and doesn't work with >= 0.16 (so it should build on ubuntu).

But I fixed it anyway.

[Cris Dywan (kalikiana)]

Thanks a lot!

[Liviu Andronic (landronimirc)]

I have managed to build midori against valac 0.14.2 on Maverick through Precise, but it fails on Lucid. I attach the relevant error message; for the full log, see [1]. Any ideas on what is going on?

[1] https://launchpad.net/~midori/+archive/ppa/+build/3425706

[Liviu Andronic (landronimirc)]

The Vala Team PPA maintainer passed me the following:
"This is caused by a too old gio-2.0 dep, It should be at least 2.26 in
this case which isnt available in lucid. You can try to drop this
external-download-manager extension which introduced this bump."

If this is so then 0.4.5 is squarely incompatible with Ubuntu Lucid, which ships libglib2.0 version 2.24.1.

Is it possible to disable the "external-download-manager" extension? Otherwise, could someone insure that the code compiles against libglib-2.24.1?

[vcap (vcappe)]

> Is it possible to disable the "external-download-manager" extension?

http://git.xfce.org/apps/midori/commit/?id=2d921d441615baa7bd1203030756b29402461ae1

( you just need to delete "bld.env['platform'] == 'win32' and" from the if line)

[Liviu Andronic (landronimirc)]

This worked very nicely, thanks. Now 0.4.5 for Lucid is on the PPA.