Favicon is not always loaded

[Arturo Torres Sánchez]

When browsing a page (for example, Gmail), sometimes the favicon is loaded and shown in the tab, but sometimes only the default webpage icon is shown. I think this happens randomly, but I can't be totally sure.

[Arturo Torres Sánchez (r2d2.art2005)]

I've noticed that it's not that random. Static pages have always their favicon correctly loaded, but favicons of dynamic pages (like Gmail, Facebook, or other webapps) usually (but not always) dissapear, especially when refreshing some inner content.

[gue5t gue5t (gue5t)]

This happens consistently on blogs from tumblr, which have an iframe loaded through javascript in the top-right corner. For example, <http://test.tumblr.com/> seems to load its icon properly the first time (possibly because the proper favicon hasn't been downloaded when javascript loads the iframe?) but upon subsequent page loads, the page flashes its correct favicon before showing the icon for text/html. Disabling javascript, which for this particular page prevents the iframe from being loaded, causes the correct icon to be shown upon page load.

[Cris Dywan (kalikiana)]

Confirm gmail and tumblr: it's a race condition, we don't check the main frame in cases such as when resetting the icon.

[Arturo Torres Sánchez (r2d2.art2005)]

I would like to reopen this bug. Although the fix is helpful, it is not complete. Here are some steps to reproduce:

1. Go to http://mail.google.com/
2. If necessary, log in.
3. Wait for it to load. Favicon is correctly shown.
4. Click any link inside the page (e.g. a mail or a label). Favicon disappears.
5. Wait for it to load. Favion does not return.

The same behavior is seen in http://facebook.com/ . Clicking a link (e.g. Messages, a group, or a person) also makes the favicon disappear.

What the fix did was made the favicon appear in the first time (before that, the favicon was never shown).

[Arturo Torres Sánchez (r2d2.art2005)]

Also, for some reason a search in Launchpad also does not show the favicon.

https://bugs.launchpad.net/midori/+bugs?field.searchtext=favicon&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&field.assignee=&field.bug_reporter=&field.omit_dupes=on&field.has_patch=&field.has_no_package=