saving download failes when the last part of the URL contains %2F

Bug #972931 reported by natano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
natano

Bug Description

When the last part of the URL contains "%2F" the suggested filename contains a slash, so midori tries to save the file in a nonexistent directory when clicking on "Open" or "Save".
Reproduction: go to https://d19vezwu8eufl6.cloudfront.net/nlp/slides%2F03-01-FormalizingNB.pdf and click on "Open" or "Save".

Revision history for this message
natano (natanoptacek) wrote :
Revision history for this message
natano (natanoptacek) wrote :
Revision history for this message
Cris Dywan (kalikiana) wrote :

I was testing it and noticed, you're not handling the allocated memory - we get a const string from webkit, but we can't modify a const string like that. It "may work" on your system if you're lucky but not on all systems.

I put the example and the upstream URL in the patch, and updated it.

Changed in midori:
status: New → In Progress
assignee: nobody → natano (natanoptacek)
Revision history for this message
natano (natanoptacek) wrote :

thank you for reviewing the patch!
Attached is a patch which addresses the issues you have described in the last comment.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks for the update. Pushed.

Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.