crash in midori_view_save_source

[gue5t gue5t]

Midori crashes when trying to view source of the page <http://tumblr.com/twitter/check> (a user must be logged into twitter to see, but the page is essentially blank).

A backtrace is attached; the crux of the bug is that midori_view_save_source (in midori-view.c:5166) performs:

data = webkit_web_data_source_get_data (data_source);

and then assumes data is non-null (e.g. on line 5190), which is not necessarily true.

[gue5t gue5t (gue5t)]

Line 5251 still references data->len and crashes after the patch. That's the only other place data's assumed non-null though.

[Cris Dywan (kalikiana)]

Indeed, thanks for pointing it out. Should be fixed this time.