2.37.5.1 : soup_uri_set_path: runtime check failed: (path != NULL)

Bug #930630 reported by dino99
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

Precise i386, logged as gnome-classic

This is a follow up of previous report bug #928820; but this time the error is different

https://bugs.launchpad.net/ubuntu/+source/libsoup2.4/+bug/928820/comments/13

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: libsoup2.4-1 2.37.5.1-0ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-15.24-generic-pae 3.2.5
Uname: Linux 3.2.0-15-generic-pae i686
NonfreeKernelModules: nvidia
ApportVersion: 1.91-0ubuntu1
Architecture: i386
Date: Sat Feb 11 14:15:38 2012
SourcePackage: libsoup2.4
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
dino99 (9d9) wrote :
dino99 (9d9)
tags: added: 2.37.5.1
Revision history for this message
Dan Winship (danw-gnome) wrote :

it still warns, but everything should still work fine anyway.

(At this point the bug is in midori; it's calling soup_uri_set_path(uri, NULL), when it should be using "" instead.)

Revision history for this message
dino99 (9d9) wrote :

Thanks Dan, have switch to midori package. The main issue is that it is flooding xsession-errors log continuously. Hopes the midori team fix that asap.

affects: libsoup2.4 (Ubuntu) → midori
Revision history for this message
dino99 (9d9) wrote :

With the new libsoup2.4 2.37.91-0ubuntu1 this issue still exist on Precise i386.

tags: added: 2.37.91-0ubuntu1
removed: 2.37.5.1
Revision history for this message
Cris Dywan (kalikiana) wrote :

Committed a fix to always use a non-NULL string (katze_str_non_null).

Changed in midori:
status: New → Fix Committed
Revision history for this message
vcap (vcappe) wrote :

nope, it's the second argument that soup_uri_set_path() is complaining about.

diff --git a/midori/main.c b/midori/main.c
index f777346..4e71832 100644
--- a/midori/main.c
+++ b/midori/main.c
@@ -983,7 +983,7 @@ midori_soup_session_settings_accept_language_cb (SoupSession* session,
             if (stripped_uri != NULL)
             {
                 gchar* stripped_referer;
- soup_uri_set_path (stripped_uri, NULL);
+ soup_uri_set_path (stripped_uri, "");
                 soup_uri_set_query (stripped_uri, NULL);
                 stripped_referer = soup_uri_to_string (stripped_uri, FALSE);
                 soup_uri_free (stripped_uri);

Revision history for this message
vcap (vcappe) wrote :

as attachment so the formating is not messed up.

Revision history for this message
Cris Dywan (kalikiana) wrote :

My apologies, and thanks for the correct patch. Pushed and reverted the previous change.

Revision history for this message
dino99 (9d9) wrote :

Seems to have been fixed with the latest dev ppa release (0.4.4+r4737-0)

Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.