can't delete bookmarks in the toplevel folder

Bug #926914 reported by vcap
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

since commit 98c87e7c katze_item_get_meta_data_value() returns NULL for empty strings; but this breaks the deletion of bookmarks in the toplevel folder because midori_bookmarks_remove_item_cb() now generate a query of the form:

    DELETE FROM bookmarks WHERE uri = 'foo://bar.baz' AND folder = '(NULL)'

which won't match any row; while it previously did:

   DELETE FROM bookmarks WHERE uri = 'foo://bar.baz' AND folder = ''

which delete the correct row.

(note that the sidepanel make it look like the bookmark is deleted; but it really isn't, as shown by the bookmarks widget in the navigation bar; and if you restart midori, the bookmark will show up in the sidepanel again)

attached is a patch to midori_bookmarks_remove_item_cb() that make it treats a NULL value for folder as "" instead, reestablishing the old behaviour.

Tags: bookmarks
Revision history for this message
vcap (vcappe) wrote :
Revision history for this message
vcap (vcappe) wrote :

> since commit 98c87e7c katze_item_get_meta_data_value() returns NULL for

 katze_item_get_meta_string(), actually.

Revision history for this message
Cris Dywan (kalikiana) wrote :

I committed a modified patch, using katze_str_non_null (previously STR_NON_NULL). Thanks a lot for tracking this down.

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.