App/Private mode page icon as window icon does not always update

[gue5t gue5t]

When in app or private mode, the Midori window uses the page favicon as the window icon. However, the icon is not updated on tab change, only on page load.

I looked into patching this but while doing so I had an idea on design:

It would be possible to enumerate the conditions in which the icon changes and have the window itself hook into each to update its icon, but this would be dependent on implementation details of the browser; there's no guarantee with such an approach that the locationaction favicon and window favicon agree, nor that the window icon is updated at the correct times if some part of MidoriBrowser's implementation changes in the future.

A possible solution would be to have the MidoriBrowser itself maintain a property specifying the current icon and update it when the current tab changes or the current tab's icon changes. This would provide the basis for correctly setting the window icon in app/private modes, and would allow for refactoring the favicon in the locationaction so that both mechanisms use the browser's icon. Thoughts?

[Cris Dywan (kalikiana)]

As you mentioned the location icon, I went ahead and made the browser always update the window icon together with the location icon if in app or private browsing mode. So the code in main() is no longer needed.