Midori Web Browser

multiple windows each create menu button when hiding menubar

Bug #903003 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

To reproduce:

1. Ensure that the menubar is enabled.
2. Open two browser windows.
3. Disable the menubar.
There will be two menu buttons in the navigationbar, instead of the expected one.

Tags: regression
Revision history for this message
Cris Dywan (kalikiana) wrote :

This is a regression introduced by bug 853023. I'm looking into it.

tags: added: regression
Revision history for this message
Cris Dywan (kalikiana) wrote :

So I noticed _midori_browser_save_toolbar_items is not used for anything else than changing the toolbar after (de)activating the menubar and went ahead to merge the functions and make the end result simpler. Now in fact CompactMenu is always skipped and only appended once if the menubar is hidden. Thus there are no duplicates and it can't appear in the toolbar editor.

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.