Crash in the bookmark dialog with Gtk+ 2.24

[xapantu]

There is a crash in the bookmark dialog when we press [add] (because it tries to mix a custom model of gtk_combo_box_text and the gtk_combo_box_text_get_active_text functions).

Here is a patch to fix it.

[Tylana (tylana)]

This is a very bad bug. You can't add bookmarks - crashes every time and this is an important feature for a bookmark bar, speeddial, and bookmarks section - it totally ruins the browsing experience. Hopefully Midori PPA will update this because I know nothing about how to patch myself.

[Daniel Letzeisen (dtl131)]

I ran into the same combo box issue issue with the statusbar extension. See bug https://bugs.launchpad.net/bugs/878449
I suggest you rework your patch to keep the current code and use #if HAVE_GTK3 for your code, because trying to use the newer combo box text functions for gtk2 will require a more recent version of gtk2 than midori currently requires.

[xapantu (xapantu)]

Hum, I doubt it would change anything for the gtk version, because
midori already uses these functions names (which are defined as macro
if the gtk version is too old).

[Cris Dywan (kalikiana)]

So I ended up mering the code in the form of midori_bookmark_folder_button_new and midori_bookmark_folder_button_get_active since the import had the same problematic use of a combo box. Basically the implementation changed and it was by accident that it worked and nobody noticed the problem before.