Midori fails to build with gtk3

[Daniel Letzeisen]

There is a problem with gtk3 as of git commit b5aad2d17650ba11677d397cc890ba0787f74ebb
default/extensions/history-list.c: In function ‘history_list_tab_window_construct’:
default/extensions/history-list.c:670:2: error: too many arguments to function ‘gtk_requisition_new’

I guess there's an error in history-list.vala

Workaround:
For those building with gtk3, run ./waf build until it errors out, then apply the patch or manually make the adjustments to _build_/default/extensions/history-list.c, then run ,./waf build again to finish building.

[Cris Dywan (kalikiana)]

We can't use that patch unfortunately. The extension is written in Vala and the error is in the generated C code. If it's a Vala bug we need to find a way to work around it.

[Daniel Letzeisen (dtl131)]

I understand that the issue is in the Vala file, and I only posted the patch as a workaround for those who want to use gtk3 until the bug is fixed. Unfortunately, I don't enough about Vala to fix/patch the bug. Thanks for confirming the bug.

[Daniel Letzeisen (dtl131)]

I'm using Debian sid and the default version of Vala is 0.12.1. Removing this and using Vala 0.14.0 allows midori to build normally.

[Daniel Letzeisen (dtl131)]

Related Vala bug: https://bugzilla.gnome.org/show_bug.cgi?id=642298
This bug was fixed in Vala 0.13.2 (released on August 16, 2011)
So if building with --enable-gtk3, you probably should check for Vala >= 0.13.2, or error out of configure.

[Cris Dywan (kalikiana)]

I added a check to the wscript as suggested.

[Daniel Letzeisen (dtl131)]

It looks good. Thank you.

[Daniel Letzeisen (dtl131)]

Actually, your check will incorrectly cause build failure on systems with Vala 0.14.0 (for example). Since there was only one release of Vala 0.13.x, removing the following line should work:
and conf.env['VALAC_VERSION'][2] >= 2)):