inspector cannot be resized

Bug #867582 reported by ManDay
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Confirmed
Undecided
ManDay

Bug Description

Since the beginning of midori, the inspector cannot be resized properly. I think either ivaldi or M.o.D. had a patch for it once, but it appears to never have made it into master. This is pretty annoying.

Tags: gtk3 inspector
Revision history for this message
Samuel Creshal (samuel-creshal) wrote :

"Annoying" is a nice understatement. It's pretty much unusable unless you happen to have 2 same-sized monitors so that monster can fit on the second.

Revision history for this message
gue5t gue5t (gue5t) wrote :

This patch makes the inspector resizable, but it isn't a very clean way of doing so, and the minimum size for it was chosen by guesswork (any smaller and the inspector is "crushed" by some amount) and is hardcoded. Clearly this isn't optimal, but input on a better way of making the inspector shrinkable would be much welcome; this may suffice in the meantime for users to whom the inspector is unusable at the moment.

Revision history for this message
ManDay (manday) wrote :

Please bump importance to major or critical. This *has* to be fixed. You should realize that this is a definite No-Go for every serious webdeveloper. They won't even bother complaining about it. They will throw midori right into the trash, as long as the inspector is in such a desolate state. And I'm saying this as a former web developer.

Revision history for this message
Cris Dywan (kalikiana) wrote :

ManDay, you can help out actively: change the changed line, starting with a +, in the patch to "gtk_widget_set_size_request (inspector_view, width, height);", apply the patch and remove the previous line (_set_default_size) in the source. Then test if that solves the problem. The way I see it, it doesn't make sense to have both functions used here. The variables are 1/7 of your screen proportions as you may have guessed. If they are wrong even after my suggestion, they must be fixed to something more useful.

Changed in midori:
status: New → In Progress
assignee: nobody → ManDay (manday)
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Resizing is really screwy in Midori 0.4.2 on Ubuntu 11.10; it looks like the initial size is set, then if I resize it any bigger, it works, but then I can't resize it down in either direction. With multiple monitors it's still unusable.

Revision history for this message
gue5t gue5t (gue5t) wrote :

kalikiana: I was looking to fix this again recently; what exactly did you mean with your suggestions?

For what it's worth, the 700x100px dimensions I used in my patch are based on shrinking the inspector until some part of the window's contents is cut off rather than merely shrinking. I'm not sure if "1/7" was a reference to that or if that refers to something else that's important to fixing this bug properly. At any rate, something this annoying should really be put to rest and I'd like to see it happen.

Revision history for this message
Cris Dywan (kalikiana) wrote :

My apologies, I didn't realize it was you who posted the patch. With 1/7 I meant the default size in the code two lines above. I didn't understand where the 700x100 came from, so thanks for clarifying that. In retrospect it makes sense.
Please don't mind that I didn't perceive this as critical, the inspector is always fullscreen here. I committed the above fix.

Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
Cris Dywan (kalikiana)
tags: added: inspector
Revision history for this message
ManDay (manday) wrote :

Still not working in GTK3, it seems.

Changed in midori:
status: Fix Released → Confirmed
Cris Dywan (kalikiana)
tags: added: gtk3
Revision history for this message
Donte Greene (flykidd) wrote :

I can make the Inspector larger, but not smaller, and cant revert changes

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.