Midori Web Browser

libmidori-core should link explicitly against libjavascriptcoregtk

Bug #855978 reported by Guido Berhoerster
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Cris Dywan

Bug Description

libmidori-core uses symbols from libjavascriptcoregtk and should link explicitly against it. Attached patch fixes the issue.

Revision history for this message
Guido Berhoerster (gber) wrote :
Revision history for this message
Cris Dywan (kalikiana) wrote :

I think libjavascriptcoregtk should be 'mandatory=False'. Even better would be to make it mandatory for the webkit version which first introduced it.

Cris Dywan (kalikiana)
Changed in midori:
assignee: nobody → Christian Dywan (kalikiana)
status: New → In Progress
Revision history for this message
Cris Dywan (kalikiana) wrote :

Try this patch, please. It should work the way I suggested.

Also, please tell me your full name and email address for crediting the patch (if you want in pm). Even for half a patch I'm happy to attribute your work.

Revision history for this message
Guido Berhoerster (gber) wrote :

> Try this patch, please. It should work the way I suggested.

Sure, this works fine.

> Also, please tell me your full name and email address for crediting the patch (if you want in pm). Even for half a patch I'm happy to attribute your work.

Guido Berhoerster <gber at opensuse.org>

Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks! Committed.

Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.