Activity log for bug #836707

Date Who What changed Old value New value Message
2011-08-29 13:54:54 Olli bug added bug
2011-11-07 22:10:44 v_2e bug added subscriber v_2e
2012-04-08 00:32:58 Olli attachment added Bookmarks: database structure improved (Bug#836707) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3025702/+files/Bookmarks%3A%20database%20structure%20improved%20%28Bug%23836707%29.patch
2012-04-08 00:36:01 Olli attachment added Katze: renamed katze_item_(get|set)_name() → katze_item_(get|set)_title() https://bugs.launchpad.net/midori/+bug/836707/+attachment/3025726/+files/Katze%3A%20renamed%20katze_item_%28get%7Cset%29_name%28%29%20%E2%86%92%20katze_item_%28get%7Cset%29_title%28%29.patch
2012-04-08 02:01:55 Olli attachment added Bookmarks: Foreign Key added https://bugs.launchpad.net/midori/+bug/836707/+attachment/3025923/+files/Bookmarks%3A%20Foreign%20Key%20added.patch
2012-04-08 02:03:29 Olli midori: status New In Progress
2012-04-08 02:03:46 Olli midori: assignee gotik_ (helloolli)
2012-04-08 10:12:59 Olli attachment added ini keys in default search file corrected (name→title) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3027520/+files/ini%20keys%20in%20default%20search%20file%20corrected%20%28name%E2%86%92title%29.patch
2012-04-08 11:57:10 Olli attachment added Bookmarks: Old database structure gets automatically converted into new one https://bugs.launchpad.net/midori/+bug/836707/+attachment/3027953/+files/Bookmarks%3A%20Old%20database%20structure%20gets%20automatically%20converted%20into%20new%20one.patch
2012-04-08 19:17:36 vcap bug added subscriber vcap
2012-04-09 09:41:16 vcap attachment added crash.log https://bugs.launchpad.net/midori/+bug/836707/+attachment/3033330/+files/crash.log
2012-04-09 15:12:53 Olli attachment added Bookmarks: database structure improved https://bugs.launchpad.net/midori/+bug/836707/+attachment/3034748/+files/Bookmarks%3A%20database%20structure%20improved%20%28%23836707%29.patch
2012-04-13 12:53:38 Olli attachment added Bookmarks: Database structure improved (Bug #836707) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3058812/+files/Bookmarks%3A%20Database%20structure%20improved%20%28Bug%20%23836707%29.patch
2012-04-13 23:17:21 Cris Dywan description the current (0.4.0) database structure is impractical. i doesn’t even adheres to the first normal form. i suggest to normalize it. this would also fix related bugs such as https://bugs.launchpad.net/midori/+bug/700033 https://bugs.launchpad.net/midori/+bug/725460 https://bugs.launchpad.net/midori/+bug/711400 1th solution: folders | id (int primary), title (text), folder_id (int) bookmarks | id (int primary), title (text), folder_id (int), uri (text), desc (text), app (int), toolbar (int) where folder.folder_id and bookmarks.folder_id refer to folder.id 2th solution: bookmarks | id (int primary), title (text), folder (int), uri (text), desc (text), app (int), toolbar (int) where bookmarks.folder refers to bookmarks.id the current (0.4.0) database structure is impractical. i doesn’t even adheres to the first normal form. i suggest to normalize it. this would also fix related bugs such as bug 700033 bug 725460 bug 711400 1th solution:   folders | id (int primary), title (text), folder_id (int)   bookmarks | id (int primary), title (text), folder_id (int), uri (text), desc (text), app (int), toolbar (int) where folder.folder_id and bookmarks.folder_id refer to folder.id 2th solution:   bookmarks | id (int primary), title (text), folder (int), uri (text), desc (text), app (int), toolbar (int) where bookmarks.folder refers to bookmarks.id
2012-04-14 13:06:48 Cris Dywan tags bookmarks database bookmarks database review
2012-04-15 21:28:26 vcap attachment added fix_menubar.diff https://bugs.launchpad.net/midori/+bug/836707/+attachment/3073792/+files/fix_menubar.diff
2012-04-17 14:46:22 vcap attachment added transaction.c https://bugs.launchpad.net/midori/+bug/836707/+attachment/3084075/+files/transaction.c
2012-04-19 22:21:57 vcap attachment added 0001-Rework-bookmarks-conversion-code.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3094723/+files/0001-Rework-bookmarks-conversion-code.patch
2012-04-19 22:42:23 vcap attachment added Bookmarks_Database_structure_improved_on_top_of_983821.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3094751/+files/Bookmarks_Database_structure_improved_on_top_of_983821.patch
2012-04-27 12:02:18 Olli attachment added Bookmarks: Database structure improved (Bug #836707) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3108469/+files/Bookmarks%3A%20Database%20structure%20improved%20%28Bug%20%23836707%29.patch
2012-04-29 15:59:51 Olli attachment added Bookmarks: Database structure improved (Bug #836707) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3115697/+files/Bookmarks%3A%20Database%20structure%20improved%20%28Bug%20%23836707%29.patch
2012-04-29 17:28:59 vcap attachment added Bookmarks_Database_structure_improved_on_top_of_983821.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3116621/+files/Bookmarks_Database_structure_improved_on_top_of_983821.patch
2012-04-29 18:15:27 vcap attachment added Bookmarks_Database_structure_improved_on_top_of_983821.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3116815/+files/Bookmarks_Database_structure_improved_on_top_of_983821.patch
2012-04-30 15:54:40 vcap attachment added 0001-Rework-bookmarks-conversion-code.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3120812/+files/0001-Rework-bookmarks-conversion-code.patch
2012-04-30 16:07:29 vcap attachment added 0001-Rework-bookmarks-conversion-code.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3120857/+files/0001-Rework-bookmarks-conversion-code.patch
2012-05-01 18:10:02 vcap attachment added 0001-Rework-bookmarks-conversion-code.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3123450/+files/0001-Rework-bookmarks-conversion-code.patch
2012-05-01 18:25:56 vcap attachment added 0001-Rework-bookmarks-conversion-code.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3123502/+files/0001-Rework-bookmarks-conversion-code.patch
2012-06-11 09:44:03 Olli attachment added Bookmarks: Database structure improved (Bug #836707) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3184647/+files/Bookmarks%3A%20Database%20structure%20improved%20%28Bug%20%23836707%29.patch
2012-06-15 14:28:30 Olli attachment added Bookmarks: Database structure improved (Bug #836707) https://bugs.launchpad.net/midori/+bug/836707/+attachment/3190912/+files/Bookmarks%3A%20Database%20structure%20improved%20%28Bug%20%23836707%29.patch
2012-06-15 23:16:03 Cris Dywan attachment added 0002-Bookmarks-Database-structure-improved.diff https://bugs.launchpad.net/midori/+bug/836707/+attachment/3191491/+files/0002-Bookmarks-Database-structure-improved.diff
2012-06-16 01:08:14 vcap attachment added 0001-Move-db-creation-code-into-its-own-function.patch https://bugs.launchpad.net/midori/+bug/836707/+attachment/3191626/+files/0001-Move-db-creation-code-into-its-own-function.patch
2012-06-19 23:24:21 Cris Dywan midori: status In Progress Fix Committed
2012-09-20 22:34:46 Cris Dywan midori: status Fix Committed Fix Released