midori_view_tab_label_parent_set repacks the wrong widget for the close button

Bug #827089 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

The relevant line reads:
            gtk_box_repack (GTK_BOX (box), view->tab_close);
but the box in question is the vbox or hbox child of the GtkEventBox that is the tab label, and the view's tab_close button is enclosed in a GtkAlignment rather than being packed in a box directly, so the call fails. Replacing it with:
            gtk_box_repack (GTK_BOX (box), gtk_widget_get_parent (view->tab_close));

should fix this bug.

Tags: bitesize tabs
Revision history for this message
Cris Dywan (kalikiana) wrote :

You're right. I declared an alignment there which is repacked to make the code not only correct but also clearer.

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.