Use LibSecret to store logins [$400]

Bug #790935 reported by Christian Dywan
82
This bug affects 27 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
In Progress
Wishlist
The Lemon Man

Bug Description

It would be nice if Midori could use the GNOME or KDE keyring service to store logins, rather than its own file, if available. This applies to HTTP authentification as well as login forms, see also bug 786534.

Related branches

Revision history for this message
Christian Dywan (kalikiana) wrote :
Revision history for this message
Christian Dywan (kalikiana) wrote :
Changed in midori:
status: New → Confirmed
Michael Moroni (airon90)
tags: added: password
Revision history for this message
Christian Dywan (kalikiana) wrote :
Daniel Fore (danrabbit)
summary: - Use keyring to store logins
+ Use LibSecret to store logins
tags: added: extension
Changed in midori:
importance: Undecided → Wishlist
milestone: none → garage
Revision history for this message
Daniel Fore (danrabbit) wrote : Re: Use LibSecret to store logins
summary: - Use LibSecret to store logins
+ Use LibSecret to store logins [$250]
Revision history for this message
Robert Roth (evfool) wrote : Re: Use LibSecret to store logins [$250]

For anyone wanting to work on a patch, I have updated the extension attached to compile with the latest midori trunk, tested that storing in the keyring works.
* Retrieving didn't work for me, probably a syntax error in the JavaScript file, needs to be fixed
* the gnome-keyring calls replaced with libsecret calls
* make sure that CMake/make installs the js file in DATADIR/midori/res/

Revision history for this message
Sam Hegarty (hegarty-sam) wrote :

It looks like the current formhistory extension has this has keyring support as a TODO (http://bazaar.launchpad.net/~midori/midori/trunk/view/head:/extensions/formhistory/formhistory.c#L152). Would adding it here be the way to go? If so then what should I do about HTTP requests? Another extension or add it to formhistory?

Revision history for this message
Paweł Forysiuk (tuxator) wrote :

I think the preffered way is to work on this branch

https://code.launchpad.net/~midori/midori/formHistory3

There was a plan to rewrite form history in vala with current extension as a base (similar to what we did with adblock extension). The plan was to have some kind of (exchangeable) abstraction for storing password which you could optionally disable. For example there is no libsecret on windows or for older versions of webkitgtk that we still support. While it should not hold everything else back if you have a good abstraction is should not be much work to add some _backends_ for password storage like gnome-keyring or win crypto api for example.

Daniel Fore (danrabbit)
summary: - Use LibSecret to store logins [$250]
+ Use LibSecret to store logins [$350]
Changed in midori:
milestone: garage → 0.6.0
status: Confirmed → In Progress
assignee: nobody → The Lemon Man (lemonboy)
Daniel Fore (danrabbit)
summary: - Use LibSecret to store logins [$350]
+ Use LibSecret to store logins [$400]
Daniel Fore (danrabbit)
tags: added: bounty
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related blueprints