[speed dial] unable to create new ones

[sztruks]

since midori update to 3.5.1, it is impossible to create new speed dial. When clicking on unused speed dial, the Java window doesn't open, and an a about:blank# appears in address bar.

[Cris Dywan (kalikiana)]

Did you by any chance disable scripts?

The coming release will visually make it clearer in this case.

[sztruks (damien-thiriet77)]

Hello,

I did not disable script. I discovered however that I have those about:#blank instead of empty boxes, if I close
them then I can register a new speed dial. Recording a new speed dial always makes Midori crash however.
Lukily, new speed dials are active after recovery.
Thanks for your job!

Damien Thiriet

> Message du 15/05/11 15:25
> De : "Christian Dywan"
> A : <email address hidden>
> Copie à :
> Objet : [Bug 782111] Re: [speed dial] unable to create new ones
>
>
> Did you by any chance disable scripts?
>
> The coming release will visually make it clearer in this case.
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/782111
>
> Title:
> [speed dial] unable to create new ones
>
> Status in Midori: Webkit Web browser:
> New
>
> Bug description:
> since midori update to 3.5.1, it is impossible to create new speed
> dial. When clicking on unused speed dial, the Java window doesn't
> open, and an a about:blank# appears in address bar.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/midori/+bug/782111/+subscribe
>
>

Une messagerie gratuite, garantie à vie et des services en plus, ça vous tente ?
Je crée ma boîte mail www.laposte.net

[Yves-Alexis Perez (corsac)]

Here, adding a speed dial from the web page itself (using right click + add to speed dial) seems to work fine.

But clicking in the speed dial page (on the “click to add shortcut”) doesn't do anything.

[Paweł Forysiuk (tuxator)]

According to this report http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640473#10 it looks like
mootools.js file failed to load. Make sure it is present in "res" subfolder in midori instalation folder.
Speed dial uses a tiny bit of mootools in add function so it fails here. Strangely in this bugreport path misses
/res/ part so maybe it was not packaged properly. Should be midori/res/mootools.js

There also could be a hard to trace bug which happens sometimes.
Resource files just fail to load altogether (close and edit icons would not load as well as js file).
Refreshing speeddial page helps for the most part if that is the case.

[Yves-Alexis Perez (corsac)]

dpkg -L midori |grep mootools.js
/usr/share/midori/res/mootools.js

So it seems it's in the correct folder.

[Paweł Forysiuk (tuxator)]

Check if mootools.js is loaded in inspector in resources. Does this happen with fresh profile as well?

[Yves-Alexis Perez (corsac)]

Yes mootools.js is loaded, will try with a fresh .{cache,config}/midori.

[Yves-Alexis Perez (corsac)]

On my box, console (in “Inspect elements») shows a parse error in:

/usr/share/midori/res/mootools.js:1

It's indeed hard to debug that since it's a oneliner (is there really a reason to have it obfuscated like that on local installs btw?)

On a fresh config, the console shows:

Failed to load ressource: URL cannot be shown mootools.js

So this time it looks like an uninitialized path or something like that.

[Yves-Alexis Perez (corsac)]

And the “failed to load” error only happens at first startup.

[Yves-Alexis Perez (corsac)]

Sorry for the 3 comments in a row. mootools.js in Debian is *not* shipped by midori so it doesn't look like this is the same bug (or then it's not a midori bug at all)

[Paweł Forysiuk (tuxator)]

So i'm confused is it still broken or not?

Mootools was probably minified to be smaller when the whole speed dial was generated by javascript.
Currently Midori does not need mootools to be fair. There were some plans to make it more fancy (with aid of mootools)
but this particular contributor abandoned it i think.

So mootools is mostly a leftover currently.
I have speeddial-head.html file without this dependency if you want to test.
You can put it in ~/.local/share/res/speeddial-head.html so midori would pick up it before system-wide one.

If it is not because of mootols.js it could be a bug in 0.3.5 when html markup was not correct for empy slots
but it should not happen with 0.4.0

[Yves-Alexis Perez (corsac)]

I can't speak for the original reporter but for me the bug lies in the build of mootools.js, not in midori.

[Danielle Foré (danrabbit)]

Since this seems to be working and we've had no further movement since october, marking as fixed.