[PATCH] F5 should reload the page

[Marin]

F5 should reload the page, it's a standard.

[Marin (marin-m)]

Here's a patch.

[Marin (marin-m)]

(with a "return TRUE;" now)

[André Stösel (ivaldi)]

Personally i'm against hardcoded shortcuts, please use GtkAction instead.

[Marin (marin-m)]

> please use GtkAction instead

My patch calls a GtkAction, who does what is needed.

[Cris Dywan (kalikiana)]

From my point of view, Ctrl+R is a more portable shortcut than F5 because it is available on virtually all platforms, such as Mac, KDE, GNOME, Windows or Maemo. Thus I don't see the need to support a Windows-centric shortcut as well, also considering modern keyboards tend to not have that key, or only through a modifier.

[Marin (marin-m)]

> From my point of view, Ctrl+R is a more portable shortcut than F5 because it is available on virtually all platforms

Both may be implemented, and F5 may be ignored in the help, just to make the shortcut working for former users of browsers supporting it.

> Windows-centric

It's supported by Firefox for Linux, Epiphany, Chromium for Linux...

[Marin (marin-m)]

Christian said, on IRC:

« Support in those browsers doesn't contradict F5 being Windows-specific. Epiphany literally writes in the source "MSIE compact". And gedit doesn't use F5 for reload.
And there starts the problem if you suddenly expect that key in unrelated apps »

[Cris Dywan (kalikiana)]

I changed my mind and I apologise. Having witnessed how persistent a user can be even when the key is clearly not working, I agree this is good to have. To me it's very hard to be able to relate to, but then again I'm not a regular user.