Slider to change the size of url bar/search bar

[ikem]

Sometimes I need a wider search bar. It would be neat to have a slider to widen them when needed.

[Peter Hatina (phatina)]

When, there is location and search entry close to each other, they are placed into resizable container with handle in between them. When closing the application, there is also search entry width stored for next startup. In other case (not being together), there is no resizable container used for both widgets.

[Cris Dywan (kalikiana)]

"typedef enum {T_LOCATION, T_SEARCH, T_OTHER, T_DONTCARE} token_t;" looks very alien to me. I'd suggest something more like MidoriStartup/ MIDORI_STARTUP_BLANK_PAGE style-wise.

I notice random indentation. 4 spaces relative to the previous line OR aligned to brackets if they're not too far to the end of the line, that's the basic rule of thumb.

Mapping between T_LOCATION/ T_SEARCH and action names seems more complicated that it could be. How about defining the values as g_static_string ("Location") etc so they can be used interchangeably without switches?

[Peter Hatina (phatina)]

Kalikiana: I changed the enum to static strings, now it should look okay.

[Cris Dywan (kalikiana)]

Very nice, works very well here even when editing in the toolbar editor repeatedly. I fixed the inline declarations and added a doc comment. Thanks!

[gue5t gue5t (gue5t)]

After this commit, with a new config, midori crashes when enabling the menubar. When reopened, the menubar is present but the Location and Search entries are missing, and are concatenated without a comma in the "toolbar-items" setting in the config file.

[Cris Dywan (kalikiana)]

LocationSearch is the name of the combined action, not a typo. As you are pointing it out, maybe choosing a more distinct name is a good idea.
I confirm the crash:

(midori:17313): Gtk-CRITICAL **: IA__gtk_paned_pack1: assertion `GTK_IS_WIDGET (child)' failed

(midori:17313): Gtk-WARNING **: Can't set a parent on widget which has a parent

Then it continues to startup with:

Gtk-CRITICAL **: IA__gtk_paned_pack1: assertion `GTK_IS_WIDGET (child)' failed

[Peter Hatina (phatina)]

Forgot to add some code to save_toolbar_items callback.