In History section of Sidebar, delete should be insensitive if it doesn't delete anything

Bug #711482 reported by Danielle Foré
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Low
Tomasz Szatkowski

Bug Description

In the History section of the Sidebar, there exists a delete item in the toolbar. This item remains sensitive even when clicking it performs no action.

If there is nothing to delete, the delete button should be insensitive.

Changed in midori:
status: New → Confirmed
tags: added: bitesize
Michael Moroni (airon90)
tags: added: cleaning history
Changed in midori:
importance: Undecided → Low
Revision history for this message
Tomasz Szatkowski (szatkus) wrote :

Fixed.

Revision history for this message
Cris Dywan (kalikiana) wrote :

The fix is not complete, if I Ctrl+Click, the buttons remain sensitive.

Incidentally the report talks about the History panel whilst the patch is for the Bookmarks panel ;-)

"is" and "tree" should be named "selected" and "treeview".

I changed the variable names and committed the partial fix.

Changed in midori:
status: Confirmed → In Progress
assignee: nobody → Tomasz Szatkowski (szatkus)
Revision history for this message
Tomasz Szatkowski (szatkus) wrote :

Patch for bookmarks toolbar.

Revision history for this message
Tomasz Szatkowski (szatkus) wrote :

And for history toolbar.

Revision history for this message
Cris Dywan (kalikiana) wrote :

The indentation of midori_bookmarks_selection_changed_cb was off, I fixed that before committing.

Thanks a lot, I pushed both commits.

Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.