Adblock should validate URIs

[Michael Moroni]

I'm running Midori 0.2.2 (from launchpad) and have been struggling setting up the ad blocking feature.

I have the following pasted into the configure advertisements filter dialogue (not too intuitive as how to populate this dialogue as the link just takes you to the website)

http:%3A%2F%2Feasylist-downloads.adblockplus.org%2Feasyprivacy.txt&title= EasyPrivacy
http:%3A%2F%2Feasylist-downloads.adblockplus.org%2Feasylist.txt&title=EasyList

Adblocking appears to work initially and when the page is refreshed the ads return

Moved from FS: http://www.twotoasts.de/bugs/index.php?do=details&task_id=732

[Michael Moroni (airon90)]

Unable to load page

Problem occurred while loading the URL http:%3A%2F%2Feasylist-downloads.adblockplus.org%2Feasyprivacy.txt&title=%20EasyPrivacy

URL cannot be shown

Are you sure about the url? http://easylist-downloads.adblockplus.org/easyprivacy.txt should work (same for easylist), and we should add some message in case the url doesn't work, I guess. credits to avb for coming up with the answer!

Ian, would you please report whether this solved your problem?

argafal

[Michael Moroni (airon90)]

Tried to add the above URL but the ad blocker gui seems to not be working correctly. Eventually managed to get the URL test to appear and saved the settings. Midori will now not launch without errors and disabling the ad blocking extension.

madwoollything

[Michael Moroni (airon90)]

Apologies .... the above comments relate to version 0.1.9 concerning the gui. I'd forgot that I was only running 0.2.2 on one laptop only.

The gui is working fine on 0.2.2 and Midori is not crashing. I've pasted in the updated URL into the Configure Advertisement Filters. It still does not appear to be blocking ads unfortunately.
Please let me know if I can provide any further data.

madwoollything

[Michael Moroni (airon90)]

For me adblocking stopped to work altogether in 0.2.3, I don't know why.

murks

[Michael Moroni (airon90)]

Same here

crashal

[Michael Moroni (airon90)]

well, I removed the adblock folder from my config and re-installed midori, then it worked again.. so it might be some config that stopped working

murks

[Michael Moroni (airon90)]

The links provided on the easylist-Homepage (https://easylist-downloads.adblockplus.org/easylist.txt etc.) don't work, links w/o SSL ( http://adblockplus.mozdev.org/easylist/easylist.txt ) work fine.
Could anyone try to reproduce this?

creshal

[Michael Moroni (airon90)]

When I try to add the 's' it gets replaced with a ':' each time, same for a new line that contains https from the start

murks

[Michael Moroni (airon90)]

That's normal, and up to 0.2.3 it worked nevertheless.

creshal

[Michael Moroni (airon90)]

I've upgraded to 0.2.3 and have switched the link to http://adblockplus.mozdev.org/easylist/easylist.txt
Adblock is now working ..... thanks

madwoollything

[Samuel Creshal (samuel-creshal)]

0.3.0 broke the adblocker again.

[Alexander Butenko (avb)]

http:%3A%2F%2Feasylist-downloads.adblockplus.org%2Feasylist.txt&title=EasyList is not a valid HTTP URL.

Id rename this bug that ablock gui is missing notifications about wrong URLS. One more point is it will be nice to implement handler for apb: links which were introduced by mozilla adblock.

[Cris Dywan (kalikiana)]

The handling of https URIs was addressed as bug 699978.

[Cris Dywan (kalikiana)]

I implemented katze_uri_entry_new () which validates that the URI starts with a sensible scheme and renders the entry red otherwise. This is used in Adblock now as well as for the homepage preference and the bookmark dialogue.

[Cris Dywan (kalikiana)]

I filed bug 783044 as a follow-up for verifying IP addresses as well.