Zoom level default and step preferences

[Michael Moroni]

To allow comfotable web viewing on wild varying screen sizes and resolution, there for sure should be ability to specify zoom settings:

1. Default zoom level for new tabs
2. Zoom increment step

Webkit's default zoom of 1.0 doesn't work for all screens. For example, on my 17" 1600x1050 laptop, for each new tab I have to press Ctrl++ couple of times - there're plenty of screen space, and my eyes are overloaded enough so I'd rather see big letters. And I'd imagine that on low-res device, like PDA or tablet, one would want to set default zoom <1.0, to be able to see as much web page without scrolling, and only then zoom in to read specific parts of it.

Same goes for zooming step - for specific screen resolutions, there may be big layout changes for default Midori's step of 0.25, like horizontal scrollbar appearance. So, it makes sense to let user specify custom increment, and be able to fine-tune zoom as fits them. Surprisingly, ChangeLog tells that there was zoom stepping preference, but it was removed in 0.1.0. What a loss, please add it back in!

Finally, there's an "Enforce 96 dots per inch" preference. It might be related to zoom, but surprisingly, it's not handled by the code in any way, as 0.2.9 (grepping for internal pref if of "enforce-96-dpi" gets only one hit).

Summing up, could we: 1) have zoom step pref back; 2) default zoom pref added; 3) confusing 96 dpi pref removed. Thanks.

Moved from FS: http://www.twotoasts.de/bugs/index.php?do=details&task_id=1016

[Michael Moroni (airon90)]

Actually, git log -p doesn't show that there was configurable zoom step in midori-view.c, midori-browser.c (btw, why there's duplicat code?) but rather change like:

- webkit_web_view_zoom_in (WEBKIT_WEB_VIEW (web_view));
+ midori_view_set_zoom_level (view,
+ midori_view_get_zoom_level (view) + 0.25f);

Which is good of course, just instead of 0.25 there should be var from user prefs.

pfalcon

[Michael Moroni (airon90)]

Aha, I see, zoom step pref was there and worked, but kinda got lost when moving to newer webkit API.

pfalcon

[Michael Moroni (airon90)]

Ok, here's first step:

1. Don't use literal constants for zoom level and step, use #defines.
2. Add support for default zoom level != 1.0

So, one now can have configuration requested in the original decsription, but only at compile time.

Also, sokoke.h is probably not the best place for those constants, but that's something already included everywhere (and I don't see a teplate for config.h, it seems to be created from scratch).

pfalcon

[Cris Dywan (kalikiana)]

Please don't mark a bug as Fix Committed unless it actually went into the repository.

[Cris Dywan (kalikiana)]

As per discussion on IRC I changed the default zoom level to 10%.

I like the idea of the patch in terms of making the values configurable, but as compile-time constants they are not going to very useful.
Michael, would you care to add settings to midori-websettings.c for those values? And then possibly update the values after using Ctrl+Plus to zoom.

[Liviu Andronic (landronimirc)]

On 2011-07-09 Christian reported that the default zoom level was changed to 10%. I understand that this concerns the 'step'. However, in 0.4.6 I still get 25% increments when using 'ctrl + plus' or the 'statusbar features' extension.

As described earlier in this ticket, it is important for users to be able to increase/decrease the zoom level in a more fine-grained way, such as at 10% steps. (For what it's worth, this is what Opera does.)

[Liviu Andronic (landronimirc)]

Following the discussion in this bug I'm not sure: Does Midori currently feature a 'default zoom level' (hidden) option? Can it be set via 'config'?