Rename Private Browsing menu item

Bug #699934 reported by Danielle Foré
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Medium
Cris Dywan

Bug Description

If private browsing is activated, the Private Browsing item in the AppMenu should be toggled (checked)

Changed in midori:
importance: Undecided → Low
Revision history for this message
Michael Moroni (airon90) wrote :

IMHO a text near "Midori" should also appear if private browsing is activated...

tags: added: privatebrowsing
tags: added: bitesize
Revision history for this message
Cris Dywan (kalikiana) wrote :

Private Browsing is not a toggle, but opening a separate process. Maybe it should be hidden?

Revision history for this message
Danielle Foré (danrabbit) wrote :

could it be checked and made insensitive? So that if you are unsure that you are browsing privately, and you try again to go click it, you can see "oh yes, it's on".

Revision history for this message
Michael Moroni (airon90) wrote :

Please see bug 699969 :)

Revision history for this message
Danielle Foré (danrabbit) wrote :

We need a design decision on whether to show it Toggled, insensitive, both, or not at all. The current solution of having it shown (and clickable) creates an odd experience.

Changed in midori:
assignee: nobody → Christian Dywan (kalikiana)
tags: added: design
Revision history for this message
Cris Dywan (kalikiana) wrote :

This came up in a discussion between John, Paweł and I and we agreed on calling it "New Private Browsing Window", on the premise that bug 768572 will be resolved.

summary: - [AppMenu] show private browsing toggled
+ Rename Private Browsing menu item
Changed in midori:
status: New → Confirmed
importance: Low → Medium
Revision history for this message
Danielle Foré (danrabbit) wrote :

I think that would make this bug invalid since we're putting it in the same behavioral category as the "new tab" and "new window" items (which actually makes more sense).

Changed in midori:
status: Confirmed → Invalid
status: Invalid → Confirmed
Revision history for this message
Danielle Foré (danrabbit) wrote :

Oops, didn't see the revised description. nevermind XD

Revision history for this message
Cris Dywan (kalikiana) wrote :

Done.

Changed in midori:
status: Confirmed → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.