Midori Web Browser

crash if g_app_info_create_from_commandline fails

Bug #1708862 reported by Zhouyang Jia on 2017-08-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Midori Web Browser	New	Undecided	Unassigned

Bug Description

If the function call "g_app_info_create_from_commandline" or "g_app_info_get_default_for_type" failed to create the application, "g_app_info_launch" would cause a crash since "info" is null.

I think it's unsafe to assume that the library function would be correct. It would be better if we could handle the error properly.

Attached please find the patch against version midori-0.5.11. Hopefully, it can solve this potential bug.

Revision history for this message

Zhouyang Jia (zhouyang09) wrote on 2017-08-05:

fix the problem by adding error handling code Edit (675 bytes, text/plain)

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

fix the problem by adding error handling code Edit

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.