Midori fails to build from source with vala 0.36

Bug #1698483 reported by Jeremy Bicha on 2017-06-16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
midori (Ubuntu)

Bug Description

Midori fails to build from source with vala 0.36 which is generally included with GNOME 3.24.

Ubuntu 17.10 Alpha recently got vala 0.36.

One error was this:

/<<PKGBUILDDIR>>/extensions/apps.vala:268.47-268.50: error: Argument 1: Cannot pass value to reference or output parameter
                                store.remove (iter);
Compilation failed: 1 error(s), 0 warning(s)

I believe that particular error can be fixed by using "ref iter" instead of "iter" but that won't work with older versions of vala. There are a lot of iters used in the code.

rev. 7159 in the bazaar branch lp:midori fixes another problem.

Jeremy Bicha (jbicha) on 2017-06-16
Changed in midori (Ubuntu):
importance: Undecided → High
status: New → Triaged
description: updated
Jeremy Bicha (jbicha) wrote :

This has been "fixed" in Debian unstable/testing and Ubuntu 17.10 by removing midori since it is basically unmaintained.

dino99 (9d9) wrote :

That report has found how to compile with vala 0.36:

Maybe the proposed patches can be used/adapted for Artful compilation.

Jeremy Bicha (jbicha) wrote :

I am closing the Ubuntu task because even if Midori were buildable again (requires not just this fix but also the Webkit2 porting from their master branch that was never released as a stable version), we still aren't interesting in having Midori in Ubuntu at this time since we don't need web browsers that aren't really maintained any more.

Changed in midori (Ubuntu):
status: Triaged → Won't Fix
Christian Dywan (kalikiana) wrote :

Fixed as of latest stable.

Changed in midori:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.