midori 0.5.10 build failure with webkit2

Bug #1448425 reported by Gustavo Zacarias
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

Midori 0.5.10 is failing to build when using a webkit2-only build/target:

-----
[ 56%] Building C object midori/CMakeFiles/midori-core.dir/midori-view.c.o
[ 57%] Building C object midori/CMakeFiles/midori-core.dir/midori-history.c.o
[ 57%] [ 58%] Building C object midori/CMakeFiles/midori-core.dir/midori-browser.c.o
Building C object midori/CMakeFiles/midori-core.dir/midori-bookmarks-db.c.o
/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/midori-view.c: In function 'webkit_web_view_load_error_cb':
/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/midori-view.c:1260:5: warning: implicit declaration of function 'webkit_web_view_get_main_frame' [-Wimplicit-function-declaration]
     if (web_frame == webkit_web_view_get_main_frame (web_view))
     ^
/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/midori-view.c:1260:19: warning: comparison between pointer and integer [enabled by default]
     if (web_frame == webkit_web_view_get_main_frame (web_view))
                   ^
[ 58%] Building C object midori/CMakeFiles/midori-core.dir/midori-frontend.c.o
[ 59%] Building C object midori/CMakeFiles/midori-core.dir/midori-websettings.c.o
[ 59%] Building C object midori/CMakeFiles/midori-core.dir/sokoke.c.o
[ 60%] Building C object midori/CMakeFiles/midori-core.dir/marshal.c.o
Linking C shared library libmidori-core.so
make[3]: Leaving directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
[ 60%] Built target midori-core
make[3]: Entering directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
make[3]: Entering directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
make[3]: Entering directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
[ 60%] [ 61%] Dependee "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/CMakeFiles/midori
.dir/DependInfo.cmake" is newer than depender "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/CMakeFiles/midori.dir/depend.internal".
Dependee "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/midori/CMakeFiles/midori.dir/depend.internal".
Scanning dependencies of target midori
Generating about.c;about.h
Generating adblock/element.c;adblock/config.c;adblock/keys.c;adblock/whitelist.c;adblock/pattern.c;adblock/subscriptions.c;adblock/extension.c;adblock/filter.c;adblock/updater.c;adblock/widgets.c;adblock/options.c;tabs-minimized.h
make[3]: Leaving directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
make[3]: Entering directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
[ 62%] Building C object midori/CMakeFiles/midori.dir/main.c.o
Dependee "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/about.dir/DependInfo.cmake" is newer than depender "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/about.dir/depend.internal".
Dependee "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/about.dir/depend.internal".
Scanning dependencies of target about
Linking C executable midori
make[3]: Leaving directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
Dependee "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/adblock.dir/DependInfo.cmake" is newer than depender "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/adblock.dir/depend.internal".
Dependee "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/home/gustavoz/b/webkit8/output/build/midori-0.5.10/extensions/CMakeFiles/adblock.dir/depend.internal".
Scanning dependencies of target adblock
make[3]: Entering directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
[ 62%] Building C object extensions/CMakeFiles/about.dir/about.c.o
libmidori-core.so.0.0.0: undefined reference to `webkit_web_view_get_main_frame'
collect2: error: ld returned 1 exit status
midori/CMakeFiles/midori.dir/build.make:87: recipe for target 'midori/midori' failed
make[3]: *** [midori/midori] Error 1
make[3]: Leaving directory '/home/gustavoz/b/webkit8/output/build/midori-0.5.10'
CMakeFiles/Makefile2:111: recipe for target 'midori/CMakeFiles/midori.dir/all' failed
make[2]: *** [midori/CMakeFiles/midori.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
-----

This is because of unconditional webkit_web_view_get_main_frame() usage in midori-view.c
#ifdefing it fixes the issue, though i don't know if anything more should be done.

Related branches

Revision history for this message
Gustavo Zacarias (5-gustavo) wrote :
Changed in midori:
milestone: none → 0.6.0
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
milestone: 0.6.0 → 0.5.11
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.