adblock slow on .*.*.*. rule
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
High
|
Unassigned |
Bug Description
Since updating to Midori 0.5.8, the browser hangs for several seconds when
opening any page.
I noticed this warning (it doesn't always appear):
WARNING **: subscriptions.
And found the corresponding rule in the filter list:
https:/
.*.*.*.info/$popup
I think those dots should be escaped when building the regular expression.
This change to fixup_regex fixed the problem for me:
--- extensions/
+++ extensions/
@@ -464,6 +464,7 @@
+ case '.':
This problem didn't seem to occur in previous versions of Midori, even though
the C version of fixup_regex also didn't escape dots. I'm not sure why that is.
Related branches
- Paweł Forysiuk: Approve
- gue5t gue5t: Approve
-
Diff: 19 lines (+2/-0)1 file modifiedextensions/adblock/extension.vala (+2/-0)
Changed in midori: | |
milestone: | none → 0.5.11 |
Changed in midori: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in midori: | |
status: | Confirmed → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |