HTTP proxy server settings ignore "Port" box

Bug #1286266 reported by John Harrison on 2014-02-28
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Midori
Undecided
Unassigned

Bug Description

I'm using http://midori-browser.org/downloads/midori_0.5.7_32_.exe on Windows 7 64bit (Couldn't find a 64bit build)

On the Network tab under Preferences, I chose "HTTP proxy server" for "Proxy server"
In the URI box I put http://myproxyserver/
In the Port box I put 14253

It didn't work.

When I tried changing the URI box to http://myxproxyserver:14253/ it worked fine.

Perhaps we could scrap the "Port" box and just have a label underneath the URI box showing how to specify the URI with the port?

Hi, could You check if works as You described with Midori 0.5.8?

gue5t gue5t (gue5t) wrote :

This hasn't changed since 0.5.7 so it is probably still the case regardless. The current logic looks like this (midori-session.c:71):

...
else if (proxy_type == MIDORI_PROXY_HTTP)
{
    soup_session_remove_feature_by_type (session, SOUP_TYPE_PROXY_RESOLVER_GNOME);
    gchar* proxy = katze_object_get_string (settings, "http-proxy");
    GString* http_proxy = g_string_new (proxy);
    g_string_append_printf (http_proxy, ":%d", katze_object_get_int (settings, "http-proxy-port"));
    midori_soup_session_set_proxy_uri (session, http_proxy->str);
    g_string_free (http_proxy, TRUE);
    g_free (proxy);
}
else
...

This code just adds ":port" at the end of the URI, which isn't really the right thing to do. We should look into what our dependency libraries expect and try to improve the UI to reflect the semantics of what the settings actually do.

Changed in midori:
status: New → Confirmed
Yosha872 (yosha) wrote :

This bug affect me too, Midori v0.5.11 (Cinnamon). And there's a strange grey rectangle in middle of the window.?field.comment=This bug affect me too, Midori v0.5.11 (Cinnamon). And there's a strange grey rectangle in middle of the window (picture attached).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers