use gtk.stack in prefs dialog [$20]
Bug #1263281 reported by
Danielle Foré
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Midori Web Browser |
Fix Released
|
Low
|
Danielle Foré | ||
Bug Description
since gtk 3.10, GNOME and elementary apps are moving to using gtk.stack and stack switcher for pages instead of gtk.notebook.
Since this is a fairly new version of Gtk, support for this should first be implemented as an #ifdef
Related branches
lp:~evfool/midori/lp1263281
- Cris Dywan: Approve
-
Diff: 51 lines (+22/-2)1 file modifiedkatze/katze-preferences.c (+22/-2)
| summary: |
- use gtk.stack in prefs dialog + use gtk.stack in prefs dialog [$20] |
| tags: | added: bounty |
Revision history for this message
| Robert Roth (evfool) wrote | #1 |
| Changed in midori: | |
| assignee: | nobody → Daniel Fore (danrabbit) |
| Changed in midori: | |
| status: | Confirmed → Fix Committed |
| Changed in midori: | |
| milestone: | none → 0.5.8 |
| Changed in midori: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I generally like the idea of using a stack+stackswitcher for preferences, but I guess in Midori's case the preferences will need a reorganization to work with a stack. Stacks are designed to have at most 4 elements (given the content width in the tabs maybe 3 would be the best here), and midori preferences have way more, 7 tabs. It looks sortof strange, IMO. What do you think? Any suggestions on how to improve the solution?
See the attached screenshot, to see what I mean when I say it will need a redesign to work with stack.