Error pages in frames cause autoscroll
Bug #1235817 reported by
gue5t gue5t
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Midori Web Browser |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Right now our error pages have a button to retry with the attribute autofocus="true". This is fine on error pages which are alone, but if one loads at the bottom of a regular page, the browser will jump to it to focus the button. We should do a check when we instantiate the error page to see whether it's in a main webkitwebframe or not.
Related branches
lp:~gue5t/midori/child-frame-autofocus
- Paweł Forysiuk: Approve
- Cris Dywan: Pending requested
-
Diff: 97 lines (+44/-1)3 files modifieddata/error.html (+1/-1)
midori/midori-view.c (+12/-0)
tests/tab.vala (+31/-0)
| tags: |
added: error-page removed: error |
| Changed in midori: | |
| status: | New → Fix Committed |
Revision history for this message
| A. Person (tesoro302) wrote | #1 |
| Changed in midori: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This seems to have stopped for me since I upgraded from vala-common-0.22.0 to 0.22.1 and disabled the advertisement blocker plugin.