Add install command for po/ directory with cmake

Bug #1228159 reported by Olivier Duchateau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
High
Unassigned

Bug Description

This patch provides install command, in order to install .mo files.

Tags: cmake gettext po

Related branches

Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :
Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :

It's better to replace ${CMAKE_INSTALL_LOCALEDIR} by ${CMAKE_INSTALL_FULL_LOCALEDIR} in main CMakeLists.txt like this

--- ./CMakeLists.txt.orig 2013-09-20 16:37:11.000000000 +0000
+++ ./CMakeLists.txt 2013-09-20 17:06:22.000000000 +0000
@@ -38,7 +38,7 @@
 add_definitions("-DDOCDIR=\"${CMAKE_INSTALL_FULL_DOCDIR}\"")

 add_definitions("-DENABLE_NLS=1")
-add_definitions("-DLOCALEDIR=\"${CMAKE_INSTALL_LOCALEDIR}\"")
+add_definitions("-DLOCALEDIR=\"${CMAKE_INSTALL_FULL_LOCALEDIR}\"")

 file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/config.h" "/* # generated file (stub) */")
 add_definitions("-DHAVE_CONFIG_H=1")

And ${CMAKE_INSTALL_FULL_LOCALEDIR} by ${CMAKE_INSTALL_LOCALEDIR} in po/CMakeLists.txt

Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :
Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :

New patch for po/CMakeLists.txt it needs previous patch (comment #3).

description: updated
Revision history for this message
Cris Dywan (kalikiana) wrote :

The patches contradict each other with no explanation. I pushed a heuristic guess of what the outcome was supposed to be to a branch. Please let's avoid the confusion and just have one version that works, no patch on top of another patch mixed with inline comments.

Donte Greene (flykidd)
Changed in midori:
status: New → Fix Committed
importance: Undecided → High
Cody Garver (codygarver)
Changed in midori:
milestone: none → 0.5.6
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.