Introduce a Database API that abstracts opening, upgrade and fallback
Bug #1222157 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
High
|
Cris Dywan |
Bug Description
We want a Database base API that handles these recurring use cases:
Open the database.
Apply a schema.
Assert if files are missing.
Upgrade to a newer schema if needed.
Look in the correct folders.
Allow easy fallback to another file format eg. session.xbel or speeddial.json when needed as a signal.
I'm thinking this can be a base class that later grows more convenience like throw'ing errors instead of manually checking db.errormsg and status.
Related branches
lp:~kalikiana/midori/databaseapi
- André Stösel: Approve
-
Diff: 326 lines (+134/-81)8 files modifieddata/history/Create.sql (+13/-0)
extensions/tabby.vala (+19/-30)
midori/midori-database.vala (+76/-0)
midori/midori-history.c (+8/-32)
midori/midori-historycompletion.vala (+6/-2)
midori/midori-historydatabase.vala (+6/-9)
po/POTFILES.in (+1/-0)
tests/completion.vala (+5/-8)
description: | updated |
Changed in midori: | |
status: | Confirmed → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.