Consider Libpeas for addons
Bug #1196002 reported by
982c80311320c1b
This bug affects 5 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
High
|
Cris Dywan |
Bug Description
I think kalikiana aleady mentioned this on IRC
Related branches
lp:~kalikiana/midori/beans
- Midori Devs: Pending requested
-
Diff: 220 lines (+97/-6)7 files modifiedCMakeLists.txt (+2/-1)
extensions/example.plugin (+9/-0)
extensions/example.py (+14/-0)
katze/midori-paths.vala (+16/-0)
midori/midori-app.c (+1/-1)
midori/midori-view.c (+51/-4)
midori/midori-websettings.c (+4/-0)
lp:~midori/midori/moreBeans
- Midori Devs: Pending requested
-
Diff: 2151 lines (+954/-804)29 files modifiedCMakeLists.txt (+11/-2)
extensions/CMakeLists.txt (+89/-72)
extensions/about.vala (+6/-1)
extensions/example.py (+14/-0)
extensions/examplepy.plugin (+9/-0)
extensions/extension-manager.vala (+273/-0)
extensions/hsts.web.plugin (+8/-0)
extensions/hsts.web.vala (+176/-0)
extensions/tabs-minimized.c (+0/-87)
extensions/tabs-minimized.plugin (+9/-0)
extensions/tabs-minimized.vala (+68/-0)
extensions/web-extension.web.vala (+68/-0)
ipc/CMakeLists.txt (+50/-0)
ipc/ipc-tab.vala (+19/-0)
katze/katze.vapi (+1/-0)
katze/midori-paths.vala (+38/-6)
midori/main.c (+50/-0)
midori/midori-app.c (+1/-1)
midori/midori-extension.c (+13/-0)
midori/midori-frontend.c (+0/-10)
midori/midori-preferences.c (+1/-31)
midori/midori-settings.vala (+22/-0)
midori/midori-stock.h (+1/-1)
midori/midori-tab.vala (+18/-0)
midori/midori.vapi (+3/-1)
midori/webkit2gtk-web-extension-4.0.vapi (+1/-1)
panels/midori-extensions.c (+0/-544)
panels/midori-extensions.h (+0/-45)
po/POTFILES.in (+5/-2)
tags: | added: extensions |
Changed in midori: | |
assignee: | nobody → Christian Dywan (kalikiana) |
milestone: | none → 0.5.6 |
Changed in midori: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
Changed in midori: | |
status: | Confirmed → In Progress |
Changed in midori: | |
milestone: | 0.5.6 → 0.5.7 |
Changed in midori: | |
milestone: | 0.5.7 → garage |
Changed in midori: | |
importance: | Wishlist → High |
milestone: | garage → 0.6.0 |
Changed in midori: | |
milestone: | 0.6.0 → 0.5.12 |
Changed in midori: | |
milestone: | 0.5.12 → 0.6.0 |
To post a comment you must log in.
Recommended reading: https:/ /wiki.gnome. org/Vala/ Gedit3PluginSam ple
I just realized a ton of problems we're facing would be solved by moving to libPeas and it's actually not painful because we're not forced to port everything at once. So it's not a goodie, but we can avoid re-inventing a number of wheels here.
Benefits:
Support external extensions
Separate interfaces for Midori.View/ Browser/ App/ Completion/ SpeedDial
- The core would provide entry points; extensions no longer need to manually connect to all signals and manage lifetime of objects, a huge source for bugs at the moment
- The same interfaces can be used internally to make
- Support external/ third-party extensions first class, with a libmidori etc.
- Allow other languages to be used, such as Javascript and Python
- Based on the previous two assumptions, a website for extensions à la Firefox would become feasible
- include WebKit2 WebExtension support in the new API
Concerns:
- extension_init can remain the existing entry point; the new API would use peas_register_types (see example above)
- we have no final concept for WebKit2 yet - this is a good chance to introduce it