Show icon only doesn't work in Granite

[Cris Dywan]

When looking at bug 1023637 I realize 'show icon only' has no visible effect in Granite's dynamic notebook.

The tab is marked as "fixed" API-wise.

I also looked at setting the label to "" (null is not allowed) as follows, but it doesn't hide the label:

=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2013-05-31 09:22:08 +0000
+++ midori/midori-view.c 2013-06-06 22:24:16 +0000
@@ -3475,7 +3475,7 @@
         if (view->tab)
             g_object_set (view->tab,
                 "fixed", view->minimized,
- "label", midori_view_get_display_title (view),
+ "label", view->minimized ? "" : midori_view_get_display_title (view),
                 NULL);
         #else
         if (view->tab_label)
@@ -4907,7 +4907,8 @@
     if (view->tab == NULL)
     {
         view->tab = granite_widgets_tab_new (
- midori_view_get_display_title (view), G_ICON (view->icon), GTK_WIDGET (view));
+ view->minimized ? "" : midori_view_get_display_title (view),
+ G_ICON (view->icon), GTK_WIDGET (view));
         g_object_set (view->tab, "fixed", view->minimized, NULL);
     }
     return view->tab;

This requires fixes in Granite, making "fixed" hide the label and/ or allow setting the label to null to hide it.

[Julián Unrrein (junrrein)]

Be aware that a fix for this issue is close to getting merged, but it will change the API: instead of a 'fixed' property, there will be a 'pinned' one.

The 'fixed' property won't be removed yet, so we don't break Midori's build.

[Danielle Foré (danrabbit)]

Marking as "Invalid" for Midori since it doesn't use dynamic notebook anymore