git 0.5.0-102-gaf7e79f doesn't build in transfers.vala

Bug #1172538 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

Compiling against GTK2, webkitgtk 2.0.0, and Vala 0.20, I get:

[ 54/159] valac: extensions/transfers.vala -> _build/default/extensions/transfers.c _build/default/extensions/transfers.h _build/default/extensions/transfers.vapi _build/default/extensions/transfers.deps
../extensions/transfers.vala:168.21-168.78: warning: unhandled error `GLib.Error'
../extensions/transfers.vala:192.21-192.70: warning: unhandled error `GLib.Error'
../extensions/transfers.vala:200.21-200.87: warning: unhandled error `GLib.Error'
../extensions/transfers.vala:331.17-331.72: warning: unhandled error `GLib.Error'
../extensions/transfers.vala:415.25-415.94: warning: unhandled error `GLib.Error'
../extensions/transfers.vala:484.43-484.56: error: Argument 1: Cannot convert from `Transfers.Manager.browser_closed' to `Gtk.Widget.delete_event'
../extensions/transfers.vala:500.50-500.63: error: Argument 1: Cannot convert from `Transfers.Manager.browser_closed' to `Gtk.Widget.delete_event'

The last two errors are fatal and can be fixed with the attached patch, but it's possible other versions of Vala or GTK would ifdef logic.

Tags: gtk2 vala
Revision history for this message
gue5t gue5t (gue5t) wrote :
Revision history for this message
Cris Dywan (kalikiana) wrote :

This seems to be a GTK+2/3 difference.

Changed in midori:
status: New → Fix Committed
tags: added: gtk2
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.