Stop button doesn't stop the spinner from spinning

Bug #1162086 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

When loading a page, hitting escape or the stop button doesn't stop the spinner spinning, since <http://git.xfce.org/apps/midori/commit/?id=bd7bf7b5b04172641bbbca5e32fb7d9ac1167c2d>. This is because stops are considered load "failures", apparently; the attached patch routes stops through midori_view_load_finished, which is *not* what used to happen (e.g. the page will now scroll to its old position after a stop) but seems alright. It may be preferable to mirror exactly the old stop behavior, which isn't difficult but would be a longer patch.

Tags: loading
Revision history for this message
gue5t gue5t (gue5t) wrote :
Revision history for this message
Cris Dywan (kalikiana) wrote :

Seems like using the non-deprecated WebKit API had unintended behavior differences. It makes sense to me to solve it this way.
If anything turns out to feel wrong, it's about time to define more strictly what we expect - the unit tests don't even catch the difference right now.

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.