closing a window with transfers causes warnings

Bug #1153130 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

With latest git midori, downloading a file and then closing the window in which it was downloaded results in the following series of warnings:

(midori4:11132): Gtk-CRITICAL **: IA__gtk_widget_destroy: assertion `GTK_IS_WIDGET (widget)' failed

(midori4:11132): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GtkWidget'

(midori4:11132): Gtk-CRITICAL **: IA__gtk_widget_hide: assertion `GTK_IS_WIDGET (widget)' failed

This is because midori_transferbar_info_free runs after the widgets associated with a transfer have been destroyed in the window closing. The attached patch simplifies the logic a bit and avoids this scenario by ensuring that widget destruction is not performed from code that frees the non-UI data structures.

Revision history for this message
gue5t gue5t (gue5t) wrote :
Changed in midori:
status: New → Fix Committed
tags: added: downloadbar downloads transfers
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers