midori -a fails badly on wrong invocations

Bug #1152590 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

Running "midori -a" without a page to use results in the following:
 $ midori -a

 ** (midori:29678): ERROR **: Midori - Missing argument for -a
 zsh: trace trap (core dumped) midori -a
and running "midori -a asdf" does:
 $ midori -a asdf

 ** (midori4:29685): CRITICAL **: midori_browser_add_uri: assertion `uri != NULL' failed

 (midori4:29685): Gtk-CRITICAL **: IA__gtk_widget_grab_focus: assertion `GTK_IS_WIDGET (widget)' failed
which doesn't crash but fails to add any tabs (including about:blank). The latter behavior is also present with "midori -p asdf".

The attached patch is a fix.

Revision history for this message
gue5t gue5t (gue5t) wrote :
gue5t gue5t (gue5t)
tags: added: commandline
Revision history for this message
Cris Dywan (kalikiana) wrote :

Indeed I went one step further, I added an option to sokoke_magic_uri that makes it bail out with an error instead of returning NULL to allow a search.

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.