Unexpected "Show in Toolbar" in "Add Bookmark" dialog

Bug #1118352 reported by Philip Heinser
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Low
Danielle Foré

Bug Description

It says "In der Werkzeugleiste anzeigen" but it has to be called "In der Lesezeichenleiste anzeigen"

Related branches

Revision history for this message
Cris Dywan (kalikiana) wrote :

The English version of "In der Werkzeugleiste anzeigen" is in fact "Show in the toolbar", the translation is correct. I personally never realized this might be unexpected.

So apparently "Show in toolbar" might have to be "Show in bookmarks bar".
Personally I thought "Show in bookmarks bar" would be redundant. That part of the window is a toolbar, and it is obviously the toolbar that shows bookmarks. Calling it that would only make it harder to spot the word.
This is just my subjective opinion, though.

summary: - Add as Bookmark Dialog German translation wrong
+ Unexpected "Show in Toolbar" in "Add Bookmark" dialog
Revision history for this message
Philip Heinser (philipheinser) wrote :

When you right Click over the strings Bar it says "Lesezeichenleiste" in German so i think that they Both shoud be called the same.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Christian, I have to agree that "Show in toolbar" is not clear and that I would not really call the bookmarks bar a Toolbar (even though I know it technically is).

Changed in midori:
importance: Undecided → Low
Cody Garver (codygarver)
Changed in midori:
status: New → Confirmed
tags: added: bitesize
tags: added: string
Revision history for this message
Danielle Foré (danrabbit) wrote :

Attached a patch that changes the English string to "Show in Bookmarks Bar" and also updates instances of "Bookmarkbar" to "Bookmarks Bar"

Changed in midori:
assignee: nobody → Daniel Fore (danrabbit)
status: Confirmed → In Progress
Cody Garver (codygarver)
Changed in midori:
milestone: none → 0.5.1
Cris Dywan (kalikiana)
Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.