Midori Web Browser

Fix Clang 3.2 warnings

Bug #1097670 reported by Paul Menzel on 2013-01-09

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Midori Web Browser	Fix Released	Medium	Paul Menzel	Midori Web Browser 0.5.4 "Depanelitis Spedalia"

Bug Description

$ clang --version
Debian clang version 3.2-9 (tags/RELEASE_32/final) (based on LLVM 3.2)
Target: i386-pc-linux-gnu
Thread model: posix
$ CC=clang ./waf configure
$ ./waf build
[…]
[ 26/151] cc: midori/midori-browser.c -> _build/default/midori/midori-browser_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 27/151] cc: midori/midori-extension.c -> _build/default/midori/midori-extension_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
../midori/midori-browser.c:750:9: warning: variable 'id' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../midori/midori-browser.c:762:12: note: uninitialized use occurs here
    return id;
           ^~
../midori/midori-browser.c:750:5: note: remove the 'if' if its condition is always true
    if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../midori/midori-browser.c:745:14: note: initialize the variable 'id' to silence this warning
    gint64 id;
             ^
              = 0
1 warning generated.
[ 28/151] cc: midori/midori-frontend.c -> _build/default/midori/midori-frontend_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
../midori/midori-frontend.c:510:29: warning: comparison of constant 2147483647 with expression of type 'MidoriStartup' is always false
      [-Wtautological-constant-out-of-range-compare]
        if (load_on_startup == G_MAXINT)
            ~~~~~~~~~~~~~~~ ^ ~~~~~~~~
2 warnings generated.
[ 29/151] cc: midori/midori-history.c -> _build/default/midori/midori-history_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
2 warnings generated.
[ 30/151] cc: midori/midori-locationaction.c -> _build/default/midori/midori-locationaction_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 31/151] cc: midori/midori-panel.c -> _build/default/midori/midori-panel_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 32/151] cc: midori/midori-preferences.c -> _build/default/midori/midori-preferences_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
1 warning generated.
[ 33/151] cc: midori/midori-privatedata.c -> _build/default/midori/midori-privatedata_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 34/151] cc: midori/midori-searchaction.c -> _build/default/midori/midori-searchaction_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 35/151] cc: midori/midori-session.c -> _build/default/midori/midori-session_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 36/151] cc: midori/midori-view.c -> _build/default/midori/midori-view_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 37/151] cc: midori/midori-websettings.c -> _build/default/midori/midori-websettings_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 38/151] cc: midori/socket.c -> _build/default/midori/socket_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 39/151] cc: midori/sokoke.c -> _build/default/midori/sokoke_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 40/151] cc: _build/default/katze/midori-hsts.c -> _build/default/katze/midori-hsts_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
/src/midori/katze/midori-hsts.vala:49:10: warning: incompatible pointer types assigning to 'GCompareFunc' (aka
      'gint (*)(gconstpointer, gconstpointer)') from 'int (const char *, const char *)' [-Wincompatible-pointer-types]
        _tmp11_ = g_strcmp0;
                ^ ~~~~~~~~~
1 warning generated.
[ 41/151] cc: _build/default/katze/midori-paths.c -> _build/default/katze/midori-paths_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
midori-hsts.c:379:13: warning: unused function 'midori_hsts_read_cache_finish' [-Wunused-function]
static void midori_hsts_read_cache_finish (MidoriHSTS* self, GAsyncResult* _res_) {
            ^
midori-hsts.c:1028:13: warning: unused function 'midori_hsts_append_to_cache_finish' [-Wunused-function]
static void midori_hsts_append_to_cache_finish (MidoriHSTS* self, GAsyncResult* _res_) {
            ^
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
4 warnings generated.
[ 42/151] cc: _build/default/katze/midori-uri.c -> _build/default/katze/midori-uri_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
/src/midori/katze/midori-paths.vala:122:10: warning: incompatible pointer types assigning to 'GCompareFunc' (aka
      'gint (*)(gconstpointer, gconstpointer)') from 'int (const char *, const char *)' [-Wincompatible-pointer-types]
        _tmp88_ = g_strcmp0;
                ^ ~~~~~~~~~
1 warning generated.
[ 43/151] cc: _build/default/midori/midori-completion.c -> _build/default/midori/midori-completion_1.o
/src/midori/katze/midori-paths.vala:274:10: warning: incompatible pointer types assigning to 'GCompareFunc' (aka
      'gint (*)(gconstpointer, gconstpointer)') from 'int (const char *, const char *)' [-Wincompatible-pointer-types]
        _tmp31_ = g_strcmp0;
                ^ ~~~~~~~~~
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
/src/midori/katze/midori-paths.vala:344:20: warning: assigning to 'gchar **' (aka 'char **') from 'const gchar *const *'
      (aka 'const char *const *') discards qualifiers in nested pointer types [-Wincompatible-pointer-types]
        _tmp17_ = _tmp16_ = g_get_system_data_dirs ();
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
/src/midori/katze/midori-paths.vala:361:18: warning: warning: assigningunknown warning option to'-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?'gchar **' [-Wunknown-warning-option]
(aka 'char **') from 'const gchar *const *'
      (aka 'const char *const *') discards qualifiers in nested pointer types [-Wincompatible-pointer-types]
        _tmp2_ = _tmp1_ = g_get_system_config_dirs ();
                        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
[ 44/151] cc: _build/default/midori/midori-dialog.c -> _build/default/midori/midori-dialog_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
midori-completion.c:1444:13: warning: unused function 'midori_autocompleter_complete_wrapped_finish' [-Wunused-function]
static void midori_autocompleter_complete_wrapped_finish (MidoriAutocompleter* self, GAsyncResult* _res_) {
            ^
/src/midori/midori/midori-dialog.vala:16:46: warning: expression result unused [-Wunused-value]
                (function_target_destroy_notify == NULL) ? NULL : (function_target_destroy_notify (function_target), NULL);
                                                           ^~~~
/usr/include/clang/3.2/include/stddef.h:52:24: note: expanded from macro 'NULL'
# define NULL ((void*)0)
                       ^
/src/midori/midori/midori-dialog.vala:17:45: warning: expression result unused [-Wunused-value]
        (function_target_destroy_notify == NULL) ? NULL : (function_target_destroy_notify (function_target), NULL);
                                                   ^~~~
/usr/include/clang/3.2/include/stddef.h:52:24: note: expanded from macro 'NULL'
# define NULL ((void*)0)
                       ^
/src/midori/midori/midori-dialog.vala:21:46: warning: expression result unused [-Wunused-value]
                (function_target_destroy_notify == NULL) ? NULL : (function_target_destroy_notify (function_target), NULL);
                                                           ^~~~
/usr/include/clang/3.2/include/stddef.h:52:24: note: expanded from macro 'NULL'
# define NULL ((void*)0)
                       ^
/src/midori/midori/midori-dialog.vala:22:45: warning: expression result unused [-Wunused-value]
        (function_target_destroy_notify == NULL) ? NULL : (function_target_destroy_notify (function_target), NULL);
                                                   ^~~~
/usr/include/clang/3.2/include/stddef.h:52:24: note: expanded from macro 'NULL'
# define NULL ((void*)0)
                       ^
2 warnings generated.
[ 45/151] cc: _build/default/midori/midori-download.c -> _build/default/midori/midori-download_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
5 warnings generated.
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
[ 46/151] cc: _build/default/midori/midori-extensions-column.c -> _build/default/midori/midori-extensions-column_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 47/151] cc: _build/default/midori/midori-historycompletion.c -> _build/default/midori/midori-historycompletion_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
/src/midori/midori/midori-download.vala:91:12: warning: incompatible pointer to integer conversion assigning to 'guint64'
      (aka 'unsigned long long') from 'gconstpointer' (aka 'const void *') [-Wint-conversion]
        last_size = _tmp94_;
                  ^ ~~~~~~~
/src/midori/midori/midori-download.vala:104:61: warning: incompatible integer to pointer conversion passing 'guint64'
      (aka 'unsigned long long') to parameter of type 'gpointer' (aka 'void *') [-Wint-conversion]
                g_object_set_data_full ((GObject*) _tmp111_, "last-size", _tmp112_, NULL);
                                                                          ^~~~~~~~
/usr/include/glib-2.0/gobject/gobject.h:500:29: note: passing argument to parameter 'data' here
                                               gpointer data,
                                                               ^
/usr/share/vala-0.16/vapi/glib-2.0.vapi:1276:16: warning: passing 'const gchar *' (aka 'const char *') to parameter of type 'gchar *'
      (aka 'char *') discards qualifiers [-Wincompatible-pointer-types]
        g_strdelimit (_tmp1_, _tmp2_, _tmp3_);
                      ^~~~~~
/usr/include/glib-2.0/glib/gstrfuncs.h:100:52: note: passing argument to parameter 'string' here
gchar* g_strdelimit (gchar *string,
                                                      ^
/src/midori/midori/midori-download.vala:232:2: warning: returning 'const gchar *' (aka 'const char *') from a function with result
      type 'gchar *' (aka 'char *') discards qualifiers [-Wincompatible-pointer-types]
        g_return_val_if_fail (_tmp1_, _tmp2_);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gmessages.h:334:10: note: expanded from macro 'g_return_val_if_fail'
         return (val); \
                ^~~~~
5 warnings generated.
[ 48/151] cc: _build/default/midori/midori-panedaction.c -> _build/default/midori/midori-panedaction_1.o
/src/midori/midori/midori-historycompletion.vala:37:2: warning: incompatible pointer to integer conversion returning 'void *' from
      a function with result type 'gboolean' (aka 'int') [-Wint-conversion]
        g_return_val_if_fail (_data_->_tmp0_ != NULL, NULL);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gmessages.h:334:10: note: expanded from macro 'g_return_val_if_fail'
         return (val); \
                ^~~~~
/src/midori/midori/midori-historycompletion.vala:72:19: warning: assigning to 'const gchar *' (aka 'const char *') from
      'const unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                _data_->_tmp33_ = sqlite3_column_text (_data_->_tmp32_, 1);
                                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/src/midori/midori/midori-historycompletion.vala:73:19: warning: assigning to 'const gchar *' (aka 'const char *') from
      'const unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                _data_->_tmp35_ = sqlite3_column_text (_data_->_tmp34_, 2);
                                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
4 warnings generated.
[ 49/151] cc: _build/default/midori/midori-searchcompletion.c -> _build/default/midori/midori-searchcompletion_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
/src/midori/midori/midori-searchcompletion.vala:39:2: warning: incompatible pointer to integer conversion returning 'void *' from
      a function with result type 'gboolean' (aka 'int') [-Wint-conversion]
        g_return_val_if_fail (_data_->_tmp0_ != NULL, NULL);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gmessages.h:334:10: note: expanded from macro 'g_return_val_if_fail'
         return (val); \
                ^~~~~
[ 50/151] cc: _build/default/midori/midori-settings.c -> _build/default/midori/midori-settings_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
2 warnings generated.
[ 51/151] cc: _build/default/midori/midori-speeddial.c -> _build/default/midori/midori-speeddial_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
/src/midori/midori/midori-speeddial.vala:342:9: warning: incompatible pointer types assigning to 'GtkContainer *'
      (aka 'struct _GtkContainer *') from 'GtkWidget *' (aka 'struct _GtkWidget *') [-Wincompatible-pointer-types]
        _tmp5_ = gtk_widget_get_parent ((GtkWidget*) _tmp4_);
               ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[ 52/151] cc: _build/default/midori/midori-tab.c -> _build/default/midori/midori-tab_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
2 warnings generated.
[ 53/151] cc: _build/default/midori/midori-viewable.c -> _build/default/midori/midori-viewable_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
[ 54/151] cc: _build/default/midori/midori-viewcompletion.c -> _build/default/midori/midori-viewcompletion_1.o
clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
1 warning generated.
/src/midori/midori/midori-viewcompletion.vala:35:2: warning: incompatible pointer to integer conversion returning 'void *' from a
      function with result type 'gboolean' (aka 'int') [-Wint-conversion]
        g_return_val_if_fail (_data_->_tmp0_ != NULL, NULL);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gmessages.h:334:10: note: expanded from macro 'g_return_val_if_fail'
         return (val); \
                ^~~~~
2 warnings generated.
[…]

I am going to attach my fixes to this report here.

Tags:

Related branches

lp:~kalikiana/midori/tautological

Merged into lp:midori at revision 6244

gue5t gue5t: Approve on 2013-06-30

Revision history for this message

Paul Menzel (pm-debian) wrote on 2013-01-09:

[PATCH] wscript: Only append `-Wno-unused-but-set-variable` to `CCFLAGS` for GCC Edit (1.7 KiB, text/plain)

Clang does not know about that that switch [1] and reports a warning.

    $ CC=clang ./waf configure
    $ ./waf build
    […]
    clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
    warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
    […]

Revision history for this message

Paul Menzel (pm-debian) wrote on 2013-01-09:

[PATCH] midori/midori-browser.c: Initialize variable `id` Edit (2.5 KiB, text/plain)

    $ clang --version
    Debian clang version 3.2-9 (tags/RELEASE_32/final) (based on LLVM 3.2)
    Target: i386-pc-linux-gnu
    Thread model: posix
    […]
    [ 26/151] cc: midori/midori-browser.c -> _build/default/midori/midori-browser_1.o
    clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
    warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
    1 warning generated.
    [ 27/151] cc: midori/midori-extension.c -> _build/default/midori/midori-extension_1.o
    clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
    warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
    ../midori/midori-browser.c:750:9: warning: variable 'id' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
        if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../midori/midori-browser.c:762:12: note: uninitialized use occurs here
        return id;
               ^~
    ../midori/midori-browser.c:750:5: note: remove the 'if' if its condition is always true
        if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../midori/midori-browser.c:745:14: note: initialize the variable 'id' to silence this warning
        gint64 id;
                 ^
                  = 0
    1 warning generated.

Revision history for this message

Paul Menzel (pm-debian) wrote on 2013-01-09:

[PATCH] midori/midori-frontend.c: Remove tautological expression Edit (1.8 KiB, text/plain)

    $ clang --version
    Debian clang version 3.2-9 (tags/RELEASE_32/final) (based on LLVM 3.2)
    Target: i386-pc-linux-gnu
    Thread model: posix
    […]
    [ 28/151] cc: midori/midori-frontend.c -> _build/default/midori/midori-frontend_1.o
    clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
    warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
    ../midori/midori-frontend.c:510:29: warning: comparison of constant 2147483647 with expression of type 'MidoriStartup' is always false
          [-Wtautological-constant-out-of-range-compare]
            if (load_on_startup == G_MAXINT)
                ~~~~~~~~~~~~~~~ ^ ~~~~~~~~
    2 warnings generated.

Currently there are only four members in that enumeration type.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2013-01-10:

> [PATCH] wscript: Only append `-Wno-unused-but-set-variable` to `CCFLAGS` for GCC
> [PATCH] midori/midori-browser.c: Initialize variable `id`

These look fine, committed both.

> [PATCH] midori/midori-frontend.c: Remove tautological expression

This is the wrong solution. The part about the enumeration may be correct, but midori_frontend_diagnostic_dialog does return G_MAXINT. See the bit at the end where the dialog response is being evalutated.

Please revise the patch to keep the logic but use a new value that doesn't cause warnings.

Changed in midori:
assignee:	nobody → Paul Menzel (pm-debian)
status:	New → In Progress

RabbitBot (rabbitbot-a) on 2013-07-02

Changed in midori:
status:	In Progress → Fix Committed

Cody Garver (codygarver) on 2013-07-02

Changed in midori:
milestone:	none → 0.5.4
importance:	Undecided → Medium

Cris Dywan (kalikiana) on 2013-07-15

Changed in midori:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.