Midori Web Browser

Undo close tab doesn't work with granite

Bug #1087939 reported by swizzle
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Invalid
High
Unassigned

Bug Description

When i close for example the tab elementaryos.org.
It won't be restored on clicking Undo Close Tab.

Tags: granite

Related branches

lp:~midori/midori/deathnote
André Stösel: Approve
Paweł Forysiuk: Approve
Diff: 3403 lines (+709/-2133)
11 files modified
katze/katze-throbber.c (+0/-932)
katze/katze-throbber.h (+0/-94)
katze/katze.h (+0/-1)
midori/midori-browser.c (+148/-567)
midori/midori-notebook.vala (+526/-0)
midori/midori-preferences.c (+0/-5)
midori/midori-settings.vala (+1/-0)
midori/midori-tab.vala (+14/-1)
midori/midori-view.c (+19/-531)
midori/midori.vapi (+0/-1)
po/POTFILES.in (+1/-1)
Revision history for this message
Cris Dywan (kalikiana) wrote :

I can't reproduce, I'm assuming this was fixed - re-open if it wasn't.

Changed in midori:
status: New → Fix Released
Revision history for this message
Arturo Torres Sánchez (r2d2.art2005) wrote :

I can confirm this isn't fixed. Undo close tab opens a blank tab.

Cris Dywan (kalikiana)
Changed in midori:
status: Fix Released → Confirmed
importance: Undecided → High
Revision history for this message
jesusiniesta (jesus-iniesta) wrote :

I can't reproduce it in 0.4.3.

Revision history for this message
gue5t gue5t (gue5t) wrote :

Is it possible this is a granite-related bug?

Revision history for this message
Savannah King Norton (sln45) wrote :

It seems likely that it is a granite-related bug. The "undo close tab" option is greyed out now that I have switched to midori-granite.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Afaik undo close tab isn't implemented in Midori-Granite yet, meaning hitting Ctrl+Shift+T will simply register as Ctrl+T, opening a new (blank) tab, as Arturo observed.

Revision history for this message
Cris Dywan (kalikiana) wrote :

It has been working for a long time with granite. If this stopped working it's a new bug or a regression.

tags: added: granite
summary: - undo close tab doesn't work as expected
+ Undo close tab doesn't work with granite
Revision history for this message
daredevil (shubhamgupta731) wrote :

Its working for me with granite!!!

Revision history for this message
Savannah King Norton (sln45) wrote :

Just updated, still grayed out for me

Revision history for this message
Danielle Foré (danrabbit) wrote :

Midori doesn't use Granite DynamicNotebook anymore so this is invalid

Changed in midori:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.