midori-granite doesn't remove closed tabs from history list

[GDT]

CTRL+TAB allows you to move through your open tabs. Additionally it display a list of your open tabs through a popup.

In midori-granite, the list always contains about:blank as the list item. Selecting "about:blank" does not produce any effect.

Closing tabs does not remove the corresponding item from the popup list. In this way webpage titles are always added to the list, but they are never removed.

Selecting one of the already closed tab always bring you to the rightmost open one.

Open tabs are reordered in the popup list in the Most Recent Used (MRU) fashion. "Zombie" tabs are not, and eventually end up at the bottom of the list, before "about:blank".

[GDT (dtgnn)]

With the new version of granite, "about:blank" is gone from the pop-up list of opened tabs.

But I have some more details on the "zombie tabs" issue. I noticed that the popup list is not modified until I explicitly give focus to a tab with a mouse click. This means no tab is added to the list if I don't switch to it with my mouse. And (as I described in the original bug report) closed tabs remain forever in the popup list.

Maybe the list's update is linked to the wrong kind of event?

Anyway, to reproduce the effect:
1. Fire up the browser and navigate to a web page.
2. Hit CTRL+TAB. Nothing appears on screen (and that's OK, I guess)
3. Click on the "new tab button" on the tab bar and type a different web address for the second tab.
4. Now that your browser is displaying you the second tab, hit CTRL+TAB again. A list will popup containing only the favicon and the title of the first tab. Release the keys and you'll be brought to that tab.
5. Hit CTRL+TAB a third time. Still only one tab in the popup list. Since it's the tab you are currently on, when you release the keys you'll stay where you are.
6. Switch tab clicking with your mouse.
7. Hit CTRL+TAB. Now both tabs are displayed in the list. And this time the keyboard shortcut function as expected, bringing you back and forth.
8. Close one of the tabs and hit CTRL+TAB. The closed tab is still in the popup list. You can select it, but nothing happens.

[Cris Dywan (kalikiana)]

I just made a fix related to tab movement - I'm not certain whether this bug is affected since it's non-trivial to reproduce. You may want to try again within 24 hours (Launchpad is slow at the moment and builds are taking their time).

[GDT (dtgnn)]

I can report 50% success:
- I can switch to, and move between, tabs with CTRL+TAB without problem now.
- Closed tabs still don't get removed from the popup list.

I any case, thank you for your effort.

On Sun, Dec 2, 2012 at 8:40 PM, Christian Dywan
<email address hidden> wrote:
> I just made a fix related to tab movement - I'm not certain whether this
> bug is affected since it's non-trivial to reproduce. You may want to try
> again within 24 hours (Launchpad is slow at the moment and builds are
> taking their time).
>
> ** Summary changed:
>
> - midori-granite doesn't remove closed tabs from the popup list of tabs when switching with CTRL+TAB
> + midori-granite doesn't remove closed tabs from history list
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1073259
>
> Title:
> midori-granite doesn't remove closed tabs from history list
>
> Status in Midori: Webkit Web browser:
> New
>
> Bug description:
> CTRL+TAB allows you to move through your open tabs. Additionally it
> display a list of your open tabs through a popup.
>
> In midori-granite, the list always contains about:blank as the list
> item. Selecting "about:blank" does not produce any effect.
>
> Closing tabs does not remove the corresponding item from the popup
> list. In this way webpage titles are always added to the list, but
> they are never removed.
>
> Selecting one of the already closed tab always bring you to the
> rightmost open one.
>
> Open tabs are reordered in the popup list in the Most Recent Used
> (MRU) fashion. "Zombie" tabs are not, and eventually end up at the
> bottom of the list, before "about:blank".
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/midori/+bug/1073259/+subscriptions

[Savannah King Norton (sln45)]

The bug is not as hard for me to produce. All I need to do is click the new tab button and every tab I've ever had open begins to load. I tried to set it to "show speed dial" instead and upon restarting the program it is again in "show last used tabs." The "undo close tab" option has also been grayed out for me, not sure if it is related.

[Savannah King Norton (sln45)]

I don't appear to be having this issue anymore. I will let you know if anything changes. Package is 0.5.5+r6408-0+pkg15~ubuntu12.04.1

[Savannah King Norton (sln45)]

Nevermind, it happened again, and then it threw away my tabs. I don't understand what is happening. Is there any information I can give you?

[Savannah King Norton (sln45)]

I thought my setting change wasn't sticking because midori was crashing from tab overload, but even if I change the startup setting by hand to MIDORI_STARTUP_BLANK_PAGE in the config file it changes back to load-on-startup=MIDORI_STARTUP_DELAYED_PAGES after starting. Basically midori is unusable unless I delete the tabby database each time.

[Cris Dywan (kalikiana)]

The startup setting is an unrelated issue covered by bug 1234103.