midori building failed by external-download-manager

Bug #1038064 reported by Lödur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

I've downloaded from http://twotoasts.de/index.php/midori/ the source archive
http://archive.xfce.org/src/apps/midori/0.4/midori-0.4.6.tar.bz2#!sha1!da39a3ee5e6b4b0d3255bfef95601890afd80709

Then I've extracted files from archive
tar xvf midori-0.4.6.tar.bz2

Now I change in the midori directory
cd midori-0.4.6

and run the configure script
 ./waf configure
----
Checking for program gcc or cc : /usr/bin/gcc
Checking for program cpp : /usr/bin/cpp
Checking for program ar : /usr/bin/ar
Checking for program ranlib : /usr/bin/ranlib
Checking for gcc : ok
Checking for program valac : /usr/bin/valac
Checking for gobject-2.0 : yes
Checking for gthread-2.0 : yes
Checking for program version valac >= 0.1.6 : ok 0.14.0
Checking for program glib-genmarshal : /usr/bin/glib-genmarshal
Checking for program glib-mkenums : /usr/bin/glib-mkenums
Checking for program msgfmt : /usr/bin/msgfmt
Checking for program intltool-merge : /usr/bin/intltool-merge
Checking for header locale.h : yes
Checking for program rsvg-convert : /usr/bin/rsvg-convert
Checking for unique-1.0 >= 0.9 : yes
Checking for libnotify >= : yes
Checking for library m : yes
Checking for gmodule-2.0 >= 2.8.0 : yes
Checking for gthread-2.0 >= 2.8.0 : yes
Checking for gio-2.0 >= 2.22.0 : yes
Checking for x11 >= : yes
Checking for header X11/extensions/scrnsaver.h : yes
Checking for library Xss : yes
Checking for gtk+-2.0 >= 2.10.0 : yes
Checking for webkit-1.0 >= 1.1.17 : yes
Checking for libsoup-2.4 >= 2.27.90 : yes
Checking for libxml-2.0 >= 2.6 : yes
Checking for sqlite3 >= 3.0 : yes
Checking for header unistd.h : yes
Checking for header signal.h : yes

        Localization: yes (intltool)
        Icon optimizations: yes (rsvg-convert)
        Notifications: yes (libnotify)

        API documentation: no (gtk-doc)

'configure' finished successfully (0.524s)
----

/!\ Finally I want to build the program, but the compiling stopped thru the external-download-manager
./waf build
----
Waf: Entering directory `/users/is/midori-0.4.6/_build'
[ 55/130] cc: _build/default/extensions/external-download-manager.c -> _build/default/extensions/external-

‘EDMSteadyflowInterfaceProxy’
default/extensions/external-download-manager.c:37: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before

‘EDMSteadyflowInterfaceProxyClass’
default/extensions/external-download-manager.c:180: error: expected declaration specifiers or ‘...’ before

‘GDBusConnection’
default/extensions/external-download-manager.c:183: error: expected ‘)’ before ‘*’ token

‘GVariant’
default/extensions/external-download-manager.c:186: error: expected declaration specifiers or ‘...’ before

‘GDBusMethodInvocation’
default/extensions/external-download-manager.c:187: error: expected ‘)’ before ‘*’ token
default/extensions/external-download-manager.c:188: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token

pointer target type
/users/is/midori-0.4.6/extensions/external-download-manager.vala: In function ‘edm_steady_flow_real_download’:
/users/is/midori-0.4.6/extensions/external-download-manager.vala:186: error: ‘G_BUS_TYPE_SESSION’ undeclared

Waf: Leaving directory `/users/is/midori-0.4.6/_build'
Build failed: -> task failed (err #1):
        {task: cc external-download-manager.c -> external-download-manager_7.o}

Revision history for this message
Cris Dywan (kalikiana) wrote :

It just occurred to me: the download manager extension uses GDBus which implies GLib. 2.26 and explains these errors (I shortened the output to the relevant bits).

I will bump the minimum GLib. It's already highly advisable for various other reasons to use a newer version.

description: updated
Changed in midori:
status: New → Fix Committed
Revision history for this message
Cris Dywan (kalikiana) wrote :

I re-visited this: GLib 2.26 isn't required but extensions will be disabled, so for now an older GLib is still good enough.

Changed in midori:
status: Fix Committed → Fix Released
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Released → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.