Wscript crash with version of libsoup from quanta

Bug #1026667 reported by Stéphane Marguet
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

With the new libsoup version in quanta (2.39.4.1-0ubuntu1), waf/wscript is crashing with «ValueError: too many values to unpack» on given_major, given_minor, given_micro = given_version.split ('.')

https://launchpadlibrarian.net/110461338/buildlog_ubuntu-quantal-amd64.midori_0.4.6%2Br5061-0%2Bpkg32~quantal1_FAILEDTOBUILD.txt.gz

Revision history for this message
Stéphane Marguet (stemp) wrote :

diff --git a/wscript b/wscript
index 1623b3c..1edf6dc 100644
--- a/wscript
+++ b/wscript
@@ -94,7 +94,9 @@ def configure (conf):

     def check_version (given_version, major, minor, micro):
         if '.' in given_version:
- given_major, given_minor, given_micro = given_version.split ('.')
+ given_major, given_minor, given_micro = given_version.split ('.',2)
+ if '.' in given_micro:
+ given_micro, given_pico = given_micro.split('.',1)
         else:
             given_major, given_minor, given_micro = given_version
         return int(given_major) > major or \

Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks a lot! Committed your fix.

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.