Exception rules in adblock? Does "@@" not work?

Bug #1006726 reported by Augustine Souza
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Low
Unassigned

Bug Description

I'm using the developer version of Midori from the Launchpad ppa.

I'm using ***only*** my own filter list located at /home/user/.config/midori/extensions/libadblock.so/custom.list but I cannot get exceptions (whitelist?) to work:

For example, I have a rule to block all .gif images everywhere:

.*/.*.gif

This rule blocks all .gif images everywhere, as intended.

I then want to make an exception for a single .gif image (for example):

None of these work:
@@http://ubuntuforums.org/images/rebrand/buttons/lastpost.gif
@@||ubuntuforums.org/images/rebrand/buttons/lastpost.gif
@@||ubuntuforums.org/

The image lastpost.gif remains blocked. (I save and quit gedit after changing custom.list, empty cache and restart Midori.)

Is the use of exceptions possible in Midori and am I making some mistake in the syntax? According to the EasyList format, the first rule (@@http://ubuntuforums.org/images/rebrand/buttons/lastpost.gif) should work. Or, are exceptions not possible?

Just to clarify, I have both rules in the one file called custom.list like this:

.*/.*.gif
@@http://ubuntuforums.org/images/rebrand/buttons/lastpost.gif

about:version

Version numbers in brackets show the version used at runtime.

Command line midori
Midori 0.4.6 (de.twotoasts.midori_da4c2bbdaa50379648cefada4cc39f8e__0)
GTK+ 2.24.10 (2.24.10) Glib 2.32.1 (2.32.1)
WebKitGTK+ 1.8.1 (1.8.0) libsoup 2.38.1
cairo 1.10.2 (1.10.2)
granite No
libnotify 0.7.5
single instance libunique 1.1.6
Platform X11; Linux i686
Identification Mozilla/5.0 (X11; Linux) AppleWebKit/535.22+ Midori/0.4
Video Formats H264 [x] Ogg Theora [x] WebM [x]

Tags: adblock

Related branches

Revision history for this message
Cris Dywan (kalikiana) wrote :

The best reference on the support is the internal "AdblockPlus rule reference" in the adblock sources, see http://git.xfce.org/apps/midori/tree/extensions/adblock.c#n1349 .

It currently says "TODO: @@ is currently ignored by Midori".

tags: added: adblock
description: updated
Revision history for this message
Augustine Souza (aesouza2008) wrote : Re: [Bug 1006726] Re: Exception rules in adblock? Does "@@" not work?

Thank you for the link and the explanation :)

On Tue, Jun 12, 2012 at 1:37 AM, Christian Dywan <
<email address hidden>> wrote:

> The best reference on the support is the internal "AdblockPlus rule
> reference" in the adblock sources, see
> http://git.xfce.org/apps/midori/tree/extensions/adblock.c#n1349 .
>
> It currently says "TODO: @@ is currently ignored by Midori".
>
>

Revision history for this message
Cody Garver (codygarver) wrote :

Should whitelist (when fixed) be accessible by GUI?

Changed in midori:
status: New → Confirmed
importance: Undecided → Low
Donte Greene (flykidd)
Changed in midori:
status: Confirmed → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.