Midori finds no icons

[ManDay]

Midori finds no icons. It seems that midori bypasses Gtk's normal mechanism for generating buttons with icons and instead uses some self-crafted technique which fails. Starrting midori (GIT) with all required icons present in /usr/share/icons/Gnome ... results in the following errors. Other Gtk Applications, using the normal stock-id buttons etc, work fine.

[ManDay (manday)]

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-directory' for stock: Icon 'gtk-directory' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'user-bookmarks' for stock: Icon 'user-bookmarks' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-directory' for stock: Icon 'gtk-directory' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'stock_new-tab' for stock: Icon 'stock_new-tab' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-add' for stock: Icon 'gtk-add' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'bookmark-new' for stock: Icon 'bookmark-new' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'stock_add-bookmark' for stock: Icon 'stock_add-bookmark' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gnome-stock-trash' for stock: Icon 'gnome-stock-trash' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-undo-ltr' for stock: Icon 'gtk-undo-ltr' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'user-bookmarks' for stock: Icon 'user-bookmarks' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-directory' for stock: Icon 'gtk-directory' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'stock_new-tab' for stock: Icon 'stock_new-tab' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-add' for stock: Icon 'gtk-add' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'bookmark-new' for stock: Icon 'bookmark-new' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'stock_add-bookmark' for stock: Icon 'stock_add-bookmark' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gnome-stock-trash' for stock: Icon 'gnome-stock-trash' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-undo-ltr' for stock: Icon 'gtk-undo-ltr' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'user-bookmarks' for stock: Icon 'user-bookmarks' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-directory' for stock: Icon 'gtk-directory' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'stock_new-tab' for stock: Icon 'stock_new-tab' not present in theme

(midori4:13283): Gtk-WARNING **: Error loading theme icon 'gtk-add' for stock: Icon 'gtk-add' not present in theme

[Cris Dywan (kalikiana)]

There is midori_app_setup() in midori/midori-app.c which registers stock items that aren't included with GTK+.
GTK+ used to rely on gtk-* icon names. So GTK_STOCK_DIRECTORY was "gtk-directory" and also a valid icon name.
Themes such as Elementary started to drop these formerly correct icon names.

[Danielle Foré (danrabbit)]

Christian, these icon names have been dropped from GNOME as well. It seems everyone is moving to the FD.o naming scheme.

"gtk-directory" -> "folder"

"user-bookmarks" seems to be present in latest.

"stock_new-tab" -> "tab-new"

"gtk-add" -> "list-add"

"bookmark-new" seems to be present in latest.

"gnome-stock-trash" -> "user-trash"

"gtk-undo-ltr" -> "edit undo" and "edit-undo-rtl"

[ManDay (manday)]

I'm not quite sure I understand what's going on, but do you realize that GTK relies on an aliasing mechanism when resolving stock icons? If (which I've not yet really understood) you happen to load icons into pixbuffers yourself, you will have to go through de-aliasing icon names in the theme. A theme could map "gtk-directory" to ./scalable/misc/closed_folder.svg.

[ManDay (manday)]

Sorry, what I said is probabaly wrong - I think I confused that with fonts in X. Either way, I do have a "gtk-directory" icon.

[Cris Dywan (kalikiana)]

GTK_STOCK_DIRECTORY is defined as "gtk-directory", which *used to be* an icon name. Which is why Midori *seemingly* looks for invalid icons. It's still the internal name of the stock item.

Again, see midori_app_setup() in midori/midori-app.c for the details. Midori needs to extend the registration so it can fallback to multiple icons.

[Danielle Foré (danrabbit)]

I'm converting this into a blueprint so that we can track each icon name bug as a separate task and hopefully make some progress here ;)

https://blueprints.launchpad.net/midori/+spec/update-icon-names

As such, I'm marking this meta-report as invalid.