Failing HEPTools installation of some programs

Bug #1753514 reported by Leif Gellersen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MadGraph5_aMC@NLO
Fix Released
Undecided
Valentin Hirschi

Bug Description

An error occurs when installing some plugins using the HEPTools installer. The installation works just fine and is copied to the HEPTools folder, but in the final check (check_successfull_installation(target) in HEPToolInstaller.py), only 'install_path' and 'install_path/lib' are checked for the successful installation of the libraries. However, on my system (SUSE Linux), some libraries end up in 'install_path/lib64'. The bug is easily fixed by moving lib64 to lib then, but it took me some time to figure out what went wrong, since the installation log confirms successful installation but the install routine aborts anyway. Affected plugins are for example hepmc and ninja.

Changed in mg5amcnlo:
assignee: nobody → Valentin Hirschi (valentin-hirschi)
Revision history for this message
Valentin Hirschi (valentin-hirschi) wrote :

I have pushed what I think will be the fix.

Leif, could you try it by doing the following (you will need the revision tool bzr installed):

cd <you_MG_distribution_path>/..
bzr branch lp:~maddevelopers/mg5amcnlo/HEPToolsInstallers HEPToolsInstallers
cd <you_MG_distribution_path>
./bin/mg5_aMC
MG5_aMC>install ninja --keep_source --logging=DEBUG --local

And tell me if it goes through now on SUSE Linux.

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote : Re: [Bug 1753514] Failing HEPTools installation of some programs

Looks like Valentin push it already in the official version (maybe by mistake)

but it should be enough to do:
 install ninja --keep_source --logging=DEBUG

Cheers,

Olivier

> On 9 Mar 2018, at 13:23, Valentin Hirschi <email address hidden> wrote:
>
> I have pushed what I think will be the fix.
>
> Leif, could you try it by doing the following (you will need the
> revision tool bzr installed):
>
> cd <you_MG_distribution_path>/..
> bzr branch lp:~maddevelopers/mg5amcnlo/HEPToolsInstallers HEPToolsInstallers
> cd <you_MG_distribution_path>
> ./bin/mg5_aMC
> MG5_aMC>install ninja --keep_source --logging=DEBUG --local
>
> And tell me if it goes through now on SUSE Linux.
>
> --
> You received this bug notification because you are subscribed to
> MadGraph5_aMC@NLO.
> https://bugs.launchpad.net/bugs/1753514
>
> Title:
> Failing HEPTools installation of some programs
>
> Status in MadGraph5_aMC@NLO:
> New
>
> Bug description:
> An error occurs when installing some plugins using the HEPTools
> installer. The installation works just fine and is copied to the
> HEPTools folder, but in the final check
> (check_successfull_installation(target) in HEPToolInstaller.py), only
> 'install_path' and 'install_path/lib' are checked for the successful
> installation of the libraries. However, on my system (SUSE Linux),
> some libraries end up in 'install_path/lib64'. The bug is easily fixed
> by moving lib64 to lib then, but it took me some time to figure out
> what went wrong, since the installation log confirms successful
> installation but the install routine aborts anyway. Affected plugins
> are for example hepmc and ninja.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mg5amcnlo/+bug/1753514/+subscriptions

Revision history for this message
Leif Gellersen (leifgellersen) wrote : Re: [Bug 1753514] Re: Failing HEPTools installation of some programs

Since I solved it by hand in the meantime, I do a fresh install and try
the installation of ninja with it. Now I get an AttributeError: 'list'
object has no attribute 'endswith' in line 901 of the
HEPToolInstaller.py: all_lib = [lib for lib in all_lib if not
any(lib.endswith(ext) for ext in ['.so','.la','.dylib'])].

In case of hepmc, I now get an AttributeError: 'list' object has no
attribute 'rfind' in the HEPToolInstaller.py on line 915: if
os.path.islink(pjoin(_prefix,'lib',os.path.basename(path))):

Cheers,

Leif

On 03/09/2018 01:23 PM, Valentin Hirschi wrote:
> I have pushed what I think will be the fix.
>
> Leif, could you try it by doing the following (you will need the
> revision tool bzr installed):
>
> cd <you_MG_distribution_path>/..
> bzr branch lp:~maddevelopers/mg5amcnlo/HEPToolsInstallers HEPToolsInstallers
> cd <you_MG_distribution_path>
> ./bin/mg5_aMC
> MG5_aMC>install ninja --keep_source --logging=DEBUG --local
>
> And tell me if it goes through now on SUSE Linux.
>

Revision history for this message
Valentin Hirschi (valentin-hirschi) wrote :

Hi,

So I didn't know the syncing with our servers was so fast, and I thought I
had pushed which what would be just the test branch.
Anyway, I pushed the simply fix (sorry for this silly mistake) and it
should work now.
The fix is simply:

all_lib.append(glob.glob(pjoin(_HepTools[tool]['install_path'],libdir,'*')))
->

all_lib.extend(glob.glob(pjoin(_HepTools[tool]['install_path'],libdir,'*')))

You could test this right away by copying your directory 'HepToolsInstallers'
with the fix above in HEPToolsInstaller.py, one directory above your
madgraph installation.
And then try installing again with the additional option '--local'.

Sorry for this,

On Fri, Mar 9, 2018 at 2:06 PM, Leif Gellersen <email address hidden>
wrote:

> Since I solved it by hand in the meantime, I do a fresh install and try
> the installation of ninja with it. Now I get an AttributeError: 'list'
> object has no attribute 'endswith' in line 901 of the
> HEPToolInstaller.py: all_lib = [lib for lib in all_lib if not
> any(lib.endswith(ext) for ext in ['.so','.la','.dylib'])].
>
> In case of hepmc, I now get an AttributeError: 'list' object has no
> attribute 'rfind' in the HEPToolInstaller.py on line 915: if
> os.path.islink(pjoin(_prefix,'lib',os.path.basename(path))):
>
> Cheers,
>
> Leif
>
>
> On 03/09/2018 01:23 PM, Valentin Hirschi wrote:
> > I have pushed what I think will be the fix.
> >
> > Leif, could you try it by doing the following (you will need the
> > revision tool bzr installed):
> >
> > cd <you_MG_distribution_path>/..
> > bzr branch lp:~maddevelopers/mg5amcnlo/HEPToolsInstallers
> HEPToolsInstallers
> > cd <you_MG_distribution_path>
> > ./bin/mg5_aMC
> > MG5_aMC>install ninja --keep_source --logging=DEBUG --local
> >
> > And tell me if it goes through now on SUSE Linux.
> >
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1753514
>
> Title:
> Failing HEPTools installation of some programs
>
> Status in MadGraph5_aMC@NLO:
> New
>
> Bug description:
> An error occurs when installing some plugins using the HEPTools
> installer. The installation works just fine and is copied to the
> HEPTools folder, but in the final check
> (check_successfull_installation(target) in HEPToolInstaller.py), only
> 'install_path' and 'install_path/lib' are checked for the successful
> installation of the libraries. However, on my system (SUSE Linux),
> some libraries end up in 'install_path/lib64'. The bug is easily fixed
> by moving lib64 to lib then, but it took me some time to figure out
> what went wrong, since the installation log confirms successful
> installation but the install routine aborts anyway. Affected plugins
> are for example hepmc and ninja.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mg5amcnlo/+bug/1753514/+subscriptions
>

--
Valentin

Revision history for this message
Leif Gellersen (leifgellersen) wrote :

Now it works! Thanks!

On 03/09/2018 02:51 PM, Valentin Hirschi wrote:
> Hi,
>
> So I didn't know the syncing with our servers was so fast, and I thought I
> had pushed which what would be just the test branch.
> Anyway, I pushed the simply fix (sorry for this silly mistake) and it
> should work now.
> The fix is simply:
>
>
> all_lib.append(glob.glob(pjoin(_HepTools[tool]['install_path'],libdir,'*')))
> ->
>
> all_lib.extend(glob.glob(pjoin(_HepTools[tool]['install_path'],libdir,'*')))
>
>
> You could test this right away by copying your directory 'HepToolsInstallers'
> with the fix above in HEPToolsInstaller.py, one directory above your
> madgraph installation.
> And then try installing again with the additional option '--local'.
>
> Sorry for this,
>
>
> On Fri, Mar 9, 2018 at 2:06 PM, Leif Gellersen <email address hidden>
> wrote:
>
>> Since I solved it by hand in the meantime, I do a fresh install and try
>> the installation of ninja with it. Now I get an AttributeError: 'list'
>> object has no attribute 'endswith' in line 901 of the
>> HEPToolInstaller.py: all_lib = [lib for lib in all_lib if not
>> any(lib.endswith(ext) for ext in ['.so','.la','.dylib'])].
>>
>> In case of hepmc, I now get an AttributeError: 'list' object has no
>> attribute 'rfind' in the HEPToolInstaller.py on line 915: if
>> os.path.islink(pjoin(_prefix,'lib',os.path.basename(path))):
>>
>> Cheers,
>>
>> Leif
>>
>>
>> On 03/09/2018 01:23 PM, Valentin Hirschi wrote:
>>> I have pushed what I think will be the fix.
>>>
>>> Leif, could you try it by doing the following (you will need the
>>> revision tool bzr installed):
>>>
>>> cd <you_MG_distribution_path>/..
>>> bzr branch lp:~maddevelopers/mg5amcnlo/HEPToolsInstallers
>> HEPToolsInstallers
>>> cd <you_MG_distribution_path>
>>> ./bin/mg5_aMC
>>> MG5_aMC>install ninja --keep_source --logging=DEBUG --local
>>>
>>> And tell me if it goes through now on SUSE Linux.
>>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1753514
>>
>> Title:
>> Failing HEPTools installation of some programs
>>
>> Status in MadGraph5_aMC@NLO:
>> New
>>
>> Bug description:
>> An error occurs when installing some plugins using the HEPTools
>> installer. The installation works just fine and is copied to the
>> HEPTools folder, but in the final check
>> (check_successfull_installation(target) in HEPToolInstaller.py), only
>> 'install_path' and 'install_path/lib' are checked for the successful
>> installation of the libraries. However, on my system (SUSE Linux),
>> some libraries end up in 'install_path/lib64'. The bug is easily fixed
>> by moving lib64 to lib then, but it took me some time to figure out
>> what went wrong, since the installation log confirms successful
>> installation but the install routine aborts anyway. Affected plugins
>> are for example hepmc and ninja.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/mg5amcnlo/+bug/1753514/+subscriptions
>>
>

Changed in mg5amcnlo:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.