LiveForm.viewOnly should ignore validations and display a message
Bug #735474 reported by
Jonathan Jacobs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Methanal |
Fix Released
|
Low
|
Jonathan Jacobs | ||
Bug Description
LiveForm.viewOnly removes the ability to submit a form but doesn't ignore validators (depcheckers are probably still needed.) A message explaining that the form is in a viewing-only mode where the submit action usually is would be useful too.
Related branches
lp:~methanal-developers/methanal/improve-liveform-viewonly
- Tristan Seligmann: Approve
-
Diff: 265 lines (+72/-32)6 files modifiedmethanal/js/Methanal/Tests/TestView.js (+5/-5)
methanal/js/Methanal/Tests/Util.js (+4/-0)
methanal/js/Methanal/View.js (+52/-10)
methanal/static/styles/methanal.css (+0/-5)
methanal/themes/methanal-base/methanal-action-container.html (+2/-1)
methanal/view.py (+9/-11)
| Changed in methanal: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| milestone: | none → 0.2.2 |
| Changed in methanal: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Jonathan Jacobs (jjacobs) |
| Changed in methanal: | |
| status: | In Progress → Fix Committed |
| Changed in methanal: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
