ModalDialog shouldn't have to rely on ModalDialogForm to provide a close action
Bug #607827 reported by
Jonathan Jacobs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Methanal |
Fix Released
|
Medium
|
Jonathan Jacobs | ||
Bug Description
To close a ModalDialog the "close" method on ModalDialog must be invoked. Currently the only thing that invokes this is a "CancelAction", which is automatically added by ModalDialogForm. There should be some way to close a ModalDialog even if it does not contain a ModalDialogForm. Some suggestions would be: An "X" in the top right; pressing the "escape" key; clicking outside of the dialog.
Related branches
lp:~methanal-developers/methanal/modal-dialog-close
- Tristan Seligmann: Approve
-
Diff: 33 lines (+10/-0)2 files modifiedmethanal/static/styles/methanal.css (+7/-0)
methanal/themes/methanal-base/methanal-modal-dialog.html (+3/-0)
| Changed in methanal: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| summary: |
- ModalDialog shouldn't have to rely on ModalDialogForm to provide a - cancel action + ModalDialog shouldn't have to rely on ModalDialogForm to provide a close + action |
| Changed in methanal: | |
| milestone: | none → 0.2.2 |
| Changed in methanal: | |
| assignee: | nobody → Jonathan Jacobs (jjacobs) |
| status: | Confirmed → In Progress |
| Changed in methanal: | |
| status: | In Progress → Fix Committed |
| Changed in methanal: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
