Dictionary key-editing popup buttons do nothing

Bug #1411649 reported by Timur Sufiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Merlin
Fix Committed
High
Timur Sufiev

Bug Description

'Save'/ 'Cancel' buttons in dictionary key-editing popup are not actually connected to any functions on the scope, hence clicking them doesn't produce any effect. Key-editing popup behaviour should be changed:

1. Change the value of a specific key once 'Save' button has been clicked (in case new key value is valid).
2. Close the popup once 'Save'/'Cancel' has been clicked.
3. [optional] Use the popup directive from angular-bootstrap to make things simpler.

Paul Karikh (pkarikh)
Changed in merlin:
assignee: nobody → Paul Karikh (pkarikh)
Paul Karikh (pkarikh)
Changed in merlin:
status: New → In Progress
Timur Sufiev (tsufiev-x)
Changed in merlin:
assignee: Paul Karikh (pkarikh) → Timur Sufiev (tsufiev-x)
status: In Progress → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to merlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177594

Changed in merlin:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to merlin (master)

Reviewed: https://review.openstack.org/177594
Committed: https://git.openstack.org/cgit/stackforge/merlin/commit/?id=0efc6355f774a0301306b06fd2a9104bb023d79a
Submitter: Jenkins
Branch: master

commit 0efc6355f774a0301306b06fd2a9104bb023d79a
Author: Timur Sufiev <email address hidden>
Date: Mon Apr 27 21:26:49 2015 +0300

    Rewrite <editable> directive

    Instead of showing popup for the value being edited it now allows
    editing the same value in-place, accompanied with 2 buttons - confirm
    & reject the edit. Only when one of 2 these buttons is pressed (or
    equivalend Enter/Esc keys are pressed) the value will be applied. The
    <editable> directive could be used both for changing Action/Workflow
    entity names, for changing dictionary and varlist keys.

    Change-Id: I4e7e1c0fcaed71aa649b1c9925a9b53005ff9a2d
    Closes-Bug: #1411649

Changed in merlin:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.